~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

knotless-run: a container or overlay that fails to start says "see the log", but no log is uploaded

Closed
Closed chadtmiller.com opened this issue 0 comments
kind/bugarea/runner

In Runner::steps (crates/knotless-run/src/lib.rs), self.opts.executor.start(&setup, &log, timeout).await? (around line 1719) returns early on error, before check.log = Some(self.reporter.upload_log(&log).await?) (around line 1753). The check is filed as error with <image> did not start: see the log or the overlay at <path> was not made: see the log, but the check has no log. The same goes for an error out of run_steps (ran?).

Expected: upload what the log holds (the image pull and container start output) on every path that ends the run, so the message is true.

Found while writing the runner's design docs.