When workflows are loaded (crates/knotless/src/workflow.rs, about lines
356-374), each file whose name is not a valid workflow name is given the
fallback name invalid. Two such files then collide on that fallback.
The first one's error is replaced with more than one workflow is named invalid, <second file> among them. Neither file is named invalid, and
the real problem with the first file is lost.
How to see it
Add two files under .knotless/workflows/ whose names are not valid
workflow names, and push. The check filed for them says more than one workflow is named invalid, ..., not what is wrong with each name.
What you expected
Each badly named file reports its own name error, and the duplicate check
is skipped for the fallback name.
Where
Workflow loading (knotless crate, used by knotless-run), on main at
b191acef. Found by the docs audit.
chadtmiller.com/knotless
What happened
When workflows are loaded (crates/knotless/src/workflow.rs, about lines 356-374), each file whose name is not a valid workflow name is given the fallback name
invalid. Two such files then collide on that fallback. The first one's error is replaced withmore than one workflow is named invalid, <second file> among them. Neither file is namedinvalid, and the real problem with the first file is lost.How to see it
Add two files under
.knotless/workflows/whose names are not valid workflow names, and push. The check filed for them saysmore than one workflow is named invalid, ..., not what is wrong with each name.What you expected
Each badly named file reports its own name error, and the duplicate check is skipped for the fallback name.
Where
Workflow loading (knotless crate, used by knotless-run), on main at b191acef. Found by the docs audit.
🤖 Generated with Claude Code