Sunday, November 1
-
commented on pull Pools are read and written through grain-serve on grain.social/grain
“This runs for on: false too, so a member who has lost pool access can't withdraw a favorite. That contradicts "deleting…”
-
asked for changes on pull Pools are read and written through grain-serve on grain.social/grain
“This adds the social.grain.group.pool. methods to grain-serve. A pool is read by listing the space's repos and reading f…”
-
approved pull Private galleries are made, shared and read through grain-serve on grain.social/grain
“Nothing in this round must change. Since my last review the head moved by one commit plus a merge of spaces/support. Tha…”
-
approved pull Groups are read, joined and left through grain-serve on grain.social/grain
“I read spaces/group.rs in full. I did not read the rest of the 5,000-line diff, including the tests and the stand-in hos…”
-
approved pull A workflow step can use a step another repository shares on chadtmiller.com/knotless
“The only change since my last review is c7b230c..ad88ed2, which rewords docs/design/reusable-workflows.md to describe sh…”
-
approved pull A login asks for the space scopes of a PDS that serves spaces on grain.social/grain
“The new commit fabd19c answers my earlier note. out_of_scope now ends a session only if it is behind what a login asks o…”
-
approved pull A workflow step can use a step another repository shares on chadtmiller.com/knotless
“This adds uses: <owner>/<repo>/<step>@<version>, with the lock in .knotless/uses.lock pinning each use to a commit. It a…”
-
approved pull Private galleries are made, shared and read through grain-serve on grain.social/grain
“This pull serves private galleries from grain-serve: create, addMember, get, listMembers, and the two list methods. It a…”
-
approved pull web: Calls grain-serve by a client of its own, and logs in by its routes on grain.social/grain
“Since my last review the pull has one new commit, c1132da. It makes readPreferences and keepPreferences in preferenceSyn…”
-
approved pull web: Profiles, galleries, feeds, stories and search read from grain-serve on grain.social/grain
“Since my last review the head moved from 5b94549 to b76c2f8. The only change is a merge of web/client, which adds the co…”
-
approved pull web: Writes, reports and notifications go through grain-serve on grain.social/grain
“The only change since my last round is in preferenceSync.ts. readPreferences and keepPreferences now keep the preference…”
-
approved pull A pull opens as a draft, and its author makes it a draft again, from its page on chadtmiller.com/knotless
“Since my last review the only change is a merge of main into the branch (18a54a1), so the draft work is the same as the…”
-
approved pull web: Writes, reports and notifications go through grain-serve on grain.social/grain
“This pull moves the web's writes, reports and notifications onto grain-serve's social.grain. methods. It adds createReco…”
-
approved pull web: Profiles, galleries, feeds, stories and search read from grain-serve on grain.social/grain
“This pull moves the web's reads for profiles, the graph, galleries, feeds, stories, search and the sitemap onto grain-se…”
-
approved pull A login asks for the space scopes of a PDS that serves spaces on grain.social/grain
“This pull adds getSpaceSupport, which probes the caller's PDS (describe first, else per-method against a control NSID) a…”
-
approved pull web: Calls grain-serve by a client of its own, and logs in by its routes on grain.social/grain
“The pull is now a single commit on top of feature/rust. It still adds the typed XRPC client, the handleFetch forwarding…”
-
approved pull The web builds its lexicon types with @atproto/lex 0.4.4 on chadtmiller.com/knotless
“This bumps @atproto/lex in web/ from 0.3.14 to 0.4.4 and regenerates the lockfile. The diff is only web/package.json and…”
-
approved pull web: Calls grain-serve by a client of its own, and logs in by its routes on grain.social/grain
“Since my last review the pull has two new commits. One merges feature/rust. The other regenerates the lexicon types to i…”
-
approved pull Spaces are read and written from grain's core, tested on the alpha on grain.social/grain
“This pull adds grain::space (space URIs, credential exchange, signed reads, and Admin writes with a simplespace fallback…”
-
approved pull web: Calls grain-serve by a client of its own, and logs in by its routes on grain.social/grain
“This pull adds a generated, typed XRPC client for the web, makes handleFetch forward /xrpc, /oauth and the client-metada…”
-
approved pull A pull opens as a draft, and its author makes it a draft again, from its page on chadtmiller.com/knotless
“This adds Open as draft to the open-pull form and Convert to draft to the merge box's More menu. The menu item is shown…”
-
approved pull Labels are made and changed in a dialog, under the list on chadtmiller.com/knotless
“The only change since my last approval is in harness/e2e/private.spec.mjs. The private-repo "defining a label" flow stil…”
-
approved pull Labels and reviewers are chosen as a pull or issue opens, and a pull compares first on chadtmiller.com/knotless
“Since my last review the pull gained one commit. It changes only the private e2e flow (harness/e2e/private.spec.mjs). Th…”
-
approved pull cli: grain reports, and its admins moderate from the command line on grain.social/grain
“Carried forward: the change this pull makes at 63a427888a21ffeaaf3f433ff2c7911046b06992 is the one reviewed at f40de24d3…”
-
approved pull grain-serve scores what arrives with the classifiers, on Clef on grain.social/grain
“The new commit only merges feature/rust into the branch. What it brings in is the separate OpenGraph cards change (og/,…”
-
approved pull server: Reports come in, and admins moderate with service tokens on grain.social/grain
“The only change since my last review is one commit: "A test runs holds_json, which FIELDS otherwise only runs at compile…”
-
approved pull grain-serve draws the OpenGraph cards links unfurl into on grain.social/grain
“Carried forward: the change this pull makes at 5868302700c1f85c8bf2d62e44f37cb5f3a2615d is the one reviewed at 291b3724f…”
-
approved pull grain-serve scores what arrives with the classifiers, on Clef on grain.social/grain
“The new commit only merges feature/rust into the branch. The push sender took V9 and Index::arrived, so this pull's migr…”
-
approved pull mcp: grain-mcp moderates, and never shows a model child safety on grain.social/grain
“This head is a rebase of the one I approved last round. The top commit is the same fix. not_a_child_safety_report reads…”
-
approved pull Push registers with registerPush, falling back on servers without it on grain.social/grain-android
“The app now registers and withdraws its FCM token through social.grain.notification.registerPush / unregisterPush. It se…”
-
approved pull Push registers with registerPush, falling back on servers without it on grain.social/grain-ios
“This switches APNs registration and withdrawal to social.grain.notification.registerPush and unregisterPush. It falls ba…”
-
approved pull server: Reports come in, and admins moderate with service tokens on grain.social/grain
“The only change since my last review is a merge of feature/rust that conflicted in crates/grain-serve/src/index/schema.r…”
-
approved pull mcp: grain-mcp moderates, and never shows a model child safety on grain.social/grain
“The gap from my earlier rounds is closed. not_a_child_safety_report now fetches the open report with id by paging with c…”
-
approved pull grain-serve draws the OpenGraph cards links unfurl into on grain.social/grain
“Carried forward: the change this pull makes at 291b3724fa1aaffd4162f9c95cab29f0c151054d is the one reviewed at 4c21d180d…”
-
approved pull cli: grain reports, and its admins moderate from the command line on grain.social/grain
“The head moved to f40de24 and all four checks (check, rust, test, harness) are queued. None has finished, so I can't say…”
-
approved pull grain-serve scores what arrives with the classifiers, on Clef on grain.social/grain
“Carried forward: the change this pull makes at 4271ae5bb3eea4d07f78f253ef7f890b974dd3a5 is the one reviewed at ba2916a2b…”
-
commented on pull mcp: grain-mcp moderates, and never shows a model child safety on grain.social/grain
“This only matches an open report filed under label csae. A report with another label but a child-safety reasonType is no…”
-
asked for changes on pull mcp: grain-mcp moderates, and never shows a model child safety on grain.social/grain
“This is a new head, but not_a_child_safety_report is unchanged from the last two rounds, so the gap I asked you to close…”
-
approved pull grain-serve pushes each new record's notifications on grain.social/grain
“The new commit does what I suggested earlier. A panic while finding a record's pushes is now caught inside the index.rea…”
-
asked for changes on pull cli: grain reports, and its admins moderate from the command line on grain.social/grain
“The check, rust and test workflows pass on c88914c. The bob.test failure from last round is gone. The harness check stil…”