Sunday, November 1
-
asked for changes on pull Groups are read, joined and left through grain-serve on grain.social/grain
“This is round 3. Neither point from round 2 is fixed at the new head. I re-read join_group, leave_group and is_member th…”
-
commented on pull Pools are read and written through grain-serve on grain.social/grain
“Make this if input.on { pooling(...).await?; } so a removed member can still delete their own favorite.”
-
asked for changes on pull Pools are read and written through grain-serve on grain.social/grain
“This is the third round, and the issue from my two earlier reviews is still there. At head b3a8785, put_favorite still c…”
-
approved pull Lexicons are linted, and only grow from main's on grain.social/grain
“Since round 1 this pull merged infra/ci-gates and added lexicons to the for wf in lists in deploy.yml (both wait steps)…”
-
approved pull grain-serve logs JSON lines, a wide line a request, and slow SQL on grain.social/grain
“The method-cardinality finding from my earlier review is fixed. served now counts a request under counted_method, which…”
-
approved pull The Justfile runs grain-serve and the web, as knotless's does on grain.social/grain
“This renames justfile to Justfile, pins cargo to the stable toolchain, adds serve, web, pages and test, and makes just d…”
-
approved pull Galleries and accounts are deleted, and a deleted account only once its host agrees on grain.social/grain
“The overshoot past limit that my earlier review noted is fixed at da30f44. delete_some now asks listRecords for (budget…”
-
approved pull Stories are archived, and what each account watched follows it on grain.social/grain
“The only change since my last review is the rewrap of the module doc in crates/grain-serve/src/lib.rs. That was the one…”
-
approved pull The sitemap names the profiles and galleries a search engine may show on grain.social/grain
“This adds social.grain.server.getSitemap, with pages of galleries and profiles. A gallery is listed only if its author i…”
-
approved pull The space type private repositories are has a lexicon, dev.knotless.space on chadtmiller.com/knotless
“This adds the dev.knotless.space lexicon and teaches harness/lexicons.mjs to accept space lexicons. The harness drops on…”
-
approved pull Accounts mute and unmute, and list whom they block and mute on grain.social/grain
“Carried forward: the change this pull makes at 3c2008a56e19d9c70dfb0dd50c39d5a591de49ad is the one reviewed at af38c5ea5…”
-
approved pull Stories are archived, and what each account watched follows it on grain.social/grain
“Carried forward: the change this pull makes at 32b56f7be8fa23e6e0d3e30eab0f2f2b3aed06d5 is the one reviewed at 92f7c8c5a…”
-
approved pull The sitemap names the profiles and galleries a search engine may show on grain.social/grain
“Carried forward: the change this pull makes at 852e9b181d0de1cdc137510a7f2ac93f20b98602 is the one reviewed at ab3fa56b5…”
-
approved pull grain-serve hands the web's pages to its app, at --web on grain.social/grain
“Carried forward: the change this pull makes at 8bef4a6c904c1e81a2c71f6988474bd6f4309f43 is the one reviewed at be67d4ba6…”
-
approved pull Galleries and accounts are deleted, and a deleted account only once its host agrees on grain.social/grain
“Carried forward: the change this pull makes at 270ad01daff8bdae7dbd2411382f88a76620eda3 is the one reviewed at a7a8ce7b4…”
-
approved pull Galleries and accounts are deleted, and a deleted account only once its host agrees on grain.social/grain
“This pull adds deleteGallery, makes deleteAccount delete in steps and forget the account, makes a purge also take the ac…”
-
approved pull grain-serve has an image, /healthz, /_status and a rollout, as knotless on grain.social/grain
“Since my last round the pull has one new commit: grain-serve now shuts down gracefully on SIGTERM as well as ctrl-c. Tha…”
-
approved pull grain-serve logs JSON lines, a wide line a request, and slow SQL on grain.social/grain
“This pull gives grain-serve JSON-line logging, one wide request line per request, slow-SQL lines, RED metrics, and an ad…”
-
commented on pull The Justfile runs grain-serve and the web, as knotless's does on grain.social/grain
“{{args}} goes to grain-serve, which ignores arguments, so just serve --index target/dev/index.db (the example above) doe…”
-
commented on pull The Justfile runs grain-serve and the web, as knotless's does on grain.social/grain
“grain-serve reads no flags (main.rs uses Settings::from_vars on the environment). --index, --public-url and --jetstream…”
-
asked for changes on pull The Justfile runs grain-serve and the web, as knotless's does on grain.social/grain
“This renames justfile to Justfile, pins cargo to the stable toolchain's bin/, and adds serve, web, pages and test. It al…”
-
approved pull A workflow step can use a step another repository shares on chadtmiller.com/knotless
“The only change since my last review is 79bbc26, which makes the pinning test read the CLI's output trimmed. It touches…”
-
approved pull grain-serve has an image, /healthz, /_status and a rollout, as knotless on grain.social/grain
“This pull adds /healthz and /_status, --check-index, a deploy/Dockerfile, and a compose project with deploy.sh, rollout.…”
-
approved pull grain-serve hands the web's pages to its app, at --web on grain.social/grain
“This adds GRAIN_WEB. grain-serve now proxies every request it doesn't answer itself to the SvelteKit app. It strips the…”
-
approved pull Every query answer says it varies by who asks, as knotless's do on grain.social/grain
“Round 2 adds one commit on top of what I approved. It rewrites cached in viewer.rs to compute the Cache-Control value fi…”
-
approved pull grain-serve serves its DID document, naming its appview service on grain.social/grain
“This moves /.well-known/did.json from the hardcoded web route into grain-serve. The document is built from the server's…”
-
approved pull Lexicons are linted, and only grow from main's on grain.social/grain
“This adds a lexicons workflow and harness/lexicons.mjs. The script runs goat's lint and some checks goat doesn't make. I…”
-
approved pull grain-serve is set by flags, as knotless-serve is on grain.social/grain
“This moves grain-serve's settings from GRAIN_ variables to a table of --flags. Secrets, key files and the admin list sta…”
-
approved pull Every query answer says it varies by who asks, as knotless's do on grain.social/grain
“This adds one layer over the router. It marks every GET /xrpc/ answer Vary: authorization, cookie. It adds private, no-c…”
-
approved pull The sitemap names the profiles and galleries a search engine may show on grain.social/grain
“This adds social.grain.server.getSitemap with pages of galleries and profiles. It filters on author shown, no grain labe…”
-
approved pull Stories are archived, and what each account watched follows it on grain.social/grain
“This adds getArchive and markViewed. getArchive reuses the existing listed() and unblocked filters and the page and afte…”
-
approved pull Deploys and lexicon publishes wait on the Rust checks too on grain.social/grain
“This pull makes deploy.yml and publish-lexicons.yml wait on check test rust harness. It splits deploy's wait into checks…”
-
approved pull Private galleries are made, shared and read through grain-serve on grain.social/grain
“Nothing in the new commit needs to change, so I'm approving this round. The head moved by one commit, 16f3b73. I read th…”
-
commented on pull Groups are read, joined and left through grain-serve on grain.social/grain
“Any Err is cached as a refusal for 2 minutes, including transient failures. Cache only an explicit host refusal.”
-
commented on pull Groups are read, joined and left through grain-serve on grain.social/grain
“input.group is not checked with valid_did or is_group before call_host. Return a 400 first. leave_group needs the same c…”
-
asked for changes on pull Groups are read, joined and left through grain-serve on grain.social/grain
“This is round 2. The head is still the commit I reviewed in round 1, so neither point I raised has been addressed. Both…”
-
commented on pull Pools are read and written through grain-serve on grain.social/grain
“Call pooling only when input.on is true. As written, this refuses a member's attempt to remove their own favorite once t…”
-
asked for changes on pull Pools are read and written through grain-serve on grain.social/grain
“My earlier review asked for putFavorite to skip pooling when on is false, so a member who has lost pool access can still…”
-
approved pull Accounts mute and unmute, and list whom they block and mute on grain.social/grain
“This adds muteActor and unmuteActor, which write the existing mute table through viewer::writer, and getMutes and getBlo…”
-
approved pull A workflow step can use a step another repository shares on chadtmiller.com/knotless
“Since my last review there is one new commit, 99ac329. It adds knotless uses update, nested shared steps (at most four d…”