Sunday, November 1
-
approved pull knotless-serve: An account is dropped as deleted only when its host says so on chadtmiller.com/knotless
“This round adds only telemetry. The tracing log lines in accounts::gone and accounts::settle now go through a new teleme…”
-
approved pull deploy: grain-serve hands the pages every request it does not answer on grain.social/grain
“This runs grain-serve with --web http://pages:2601. It drops the pages' proxy network and grain-pages alias, and it cuts…”
-
commented on pull A group is started on grain's group host without leaving grain on grain.social/grain
“fields (and its jti) is computed once here and reused by the nonce resend in attempt(1). Build the body with fresh clien…”
-
asked for changes on pull A group is started on grain's group host without leaving grain on grain.social/grain
“This ports createGroup and getGroupHost onto grain-serve. create_group has the founder's PDS sign service auth for fyi.o…”
-
approved pull server: The apps sign in at their own PDS, as grain-serve's public client on grain.social/grain
“This adds /oauth/app-client-metadata.json, a native public-client document with no key, DPoP-bound, redirecting to the r…”
-
approved pull Anyone reads what grain's labels mean, as a Bluesky labeler says it on grain.social/grain
“This adds a public social.grain.moderation.describeLabels query. It returns policies (labelValues with !takedown first,…”
-
approved pull grain-import's test reads imported space invites as grain-serve does on grain.social/grain
“This changes only the grain-import test. The invite fixtures now use the real at://<did>/space/social.grain.privateGalle…”
-
approved pull knotless-serve: An account is dropped as deleted only when its host says so on chadtmiller.com/knotless
“This makes an #account deletion event drop an account only when an answer says it is gone: the DID document is 404 or 41…”
-
approved pull A workflow step can use a step another repository shares on chadtmiller.com/knotless
“This is the fifth round, and I have no new findings. The change adds uses: shared steps pinned by .knotless/uses.lock, p…”
-
approved pull The web proxy, deletes and the cross-post test land together, checked once on grain.social/grain
“This batches the web proxy, cross-post test and deletes pulls onto feature/rust. The one new commit since my approval at…”
-
approved pull The web proxy, deletes and the cross-post test land together, checked once on grain.social/grain
“My earlier round asked for accounts::gone to be three-valued, for deletions to retry on unknown, and for a test of the f…”
-
approved pull An account Jetstream says was deleted goes only when an answer says so on grain.social/grain
“This makes a Jetstream "account deleted" event purge only when an answer says the account is gone. ask returns Here, Gon…”
-
commented on pull The web proxy, deletes and the cross-post test land together, checked once on grain.social/grain
“A failed resolve_pds or getRepoStatus returns gone here, and deletions then purges state that nothing rebuilds. Treat "c…”
-
asked for changes on pull The web proxy, deletes and the cross-post test land together, checked once on grain.social/grain
“This batches the web proxy, cross-post and deletes pulls onto feature/rust. The lib.rs crate doc resolution is correct:…”
-
approved pull grain-serve hands the web's pages to its app, at --web on grain.social/grain
“Carried forward: the change this pull makes at 71971355449d6449df4ea43edc4dff98cdab641a is the one reviewed at 2b27db8b8…”
-
approved pull The web's Bluesky cross-post goes through grain-serve, and a test says so on grain.social/grain
“Carried forward: the change this pull makes at a196eff0bed177c7d852c50dbb6eb43994f76466 is the one reviewed at 521183a02…”
-
approved pull grain-serve hands the web's pages to its app, at --web on grain.social/grain
“This round is a merge of feature/rust into gaps/web. The pull's own change is unchanged since I reviewed it at 9ba88a1:…”
-
approved pull The web's Bluesky cross-post goes through grain-serve, and a test says so on grain.social/grain
“Carried forward: the change this pull makes at 521183a02db91002f3f22393ac5a72b2ee076bee is the one reviewed at 42065d02b…”
-
approved pull Groups are read, joined and left through grain-serve on grain.social/grain
“Round 5. Since round 4 the head changed only in the rule uri. views in spaces/group.rs now builds at://<group>/fyi.opens…”
-
approved pull Pools are read and written through grain-serve on grain.social/grain
“The head moved from f63abbe, which I approved, to 1caa934. The only change is a merge of spaces/groups, which brings a c…”
-
approved pull grain-serve hands the web's pages to its app, at --web on grain.social/grain
“This round folds router_with and serve_with into router and serve, which now take web: Option<&str>. I searched the bran…”
-
approved pull The web's Bluesky cross-post goes through grain-serve, and a test says so on grain.social/grain
“Carried forward: the change this pull makes at 42065d02bf4c21aed1810b84ab7ab6f3b7daa463 is the one reviewed at eea1c93b5…”
-
approved pull Private galleries are made, shared and read through grain-serve on grain.social/grain
“Nothing in this round must change, so I'm approving. Since my last review the head moved by three commits plus a merge o…”
-
approved pull Groups are read, joined and left through grain-serve on grain.social/grain
“Round 4. Both points from round 3 are fixed at this head. I re-read join_group, leave_group and is_member in spaces/grou…”
-
approved pull Pools are read and written through grain-serve on grain.social/grain
“The issue from my earlier rounds is fixed. At head f63abbe, put_favorite calls pooling only when input.on is true, with…”
-
approved pull Lexicons are linted, and only grow from main's on grain.social/grain
“Since round 2 this pull only merged infra/ci-gates again, which brought in batch/one. That brings new Rust-side work and…”
-
approved pull grain-serve hands the web's pages to its app, at --web on grain.social/grain
“This round is the same change, now read from the --web flag instead of GRAIN_WEB. It adds pages.rs, router_with and serv…”
-
approved pull grain-serve has an image, /healthz, /_status and a rollout, as knotless on grain.social/grain
“Since my last round the pull has merged in the batch and telemetry branches, plus one commit that adds --metrics 127.0.0…”
-
asked for changes on pull grain-serve logs JSON lines, a wide line a request, and slow SQL on grain.social/grain
“The method-cardinality fix from round 2 is still in. The telemetry commits I reviewed (up to bac3050) are unchanged.”
-
approved pull The Justfile runs grain-serve and the web, as knotless's does on grain.social/grain
“Since my last round the branch merged infra/deploy and infra/lexicons in. The last commit fixes a case-blind merge that…”
-
approved pull Galleries and accounts are deleted, and a deleted account only once its host agrees on grain.social/grain
“This round only merges batch/one into the branch, as the body says. The only commit of its own is the merge commit. My e…”
-
approved pull Deploys and lexicon publishes wait on the Rust checks too on grain.social/grain
“Since my last review, the pull only gained a merge of batch/one (head 8ec5991). The merge's one conflict was in harness.…”
-
approved pull Galleries and accounts are deleted, and a deleted account only once its host agrees on grain.social/grain
“This round only changes web/src/routes/settings/account/+page.svelte. It is the web caller change that earlier rounds sa…”
-
approved pull Seven reviewed pulls land on feature/rust together, checked once on grain.social/grain
“This batches seven already-reviewed pulls into feature/rust. I checked the two conflict resolutions the description name…”
-
approved pull Galleries and accounts are deleted, and a deleted account only once its host agrees on grain.social/grain
“This round only changes crates/grain-serve/tests/deletes.rs, and the change is sound. The photo fixture now includes alt…”
-
approved pull The web's Bluesky cross-post goes through grain-serve, and a test says so on grain.social/grain
“This adds crates/grain-serve/tests/cross_post.rs. It covers the web's Bluesky cross-post through social.grain.repo.: gal…”
-
approved pull grain-serve has an image, /healthz, /_status and a rollout, as knotless on grain.social/grain
“Since my last round the pull has one new commit. It reformats two healthcheck.test arrays in deploy/docker-compose.yml a…”
-
approved pull Private galleries are made, shared and read through grain-serve on grain.social/grain
“Nothing in the new commit needs to change, so I'm approving this round. The head moved by one commit, c3bfce3, and I rea…”
-
commented on pull Groups are read, joined and left through grain-serve on grain.social/grain
“Validate input.group (valid DID, is_group) with a 400 before call_host. leave_group needs the same check.”
-
commented on pull Groups are read, joined and left through grain-serve on grain.social/grain
“Cache only an explicit host refusal here. Don't cache transient errors as a refusal.”