Monday, November 2
-
approved pull Records in a space are read by their URI in full, as proposal 0016 names them on chadtmiller.com/knotless
“My earlier review asked for nothing, so there is nothing to re-check on that front. Since 9e005c7 the branch has moved t…”
-
approved pull A private repository's records are named by their URI in its space on chadtmiller.com/knotless
“I found nothing that has to change this round. The pull names a private repository's records by their full URI in the sp…”
-
approved pull A private repository's records are named in full, and public-form references are moved on chadtmiller.com/knotless
“This pull moves an account's own space records to full-form references the first time knotless writes there for them. It…”
Sunday, November 1
-
approved pull Records in a space are read by their URI in full, as proposal 0016 names them on chadtmiller.com/knotless
“Carried forward: the change this pull makes at c8240a2a3e6a017afe4f6c13c547e133374e671c is the one reviewed at 9e005c78b…”
-
approved pull A private repository's records are named by their URI in its space on chadtmiller.com/knotless
“Carried forward: the change this pull makes at b2dc7012673458ac9e99d639b3beb3585053cd5f is the one reviewed at ea543102b…”
-
approved pull A private repository's records are named in full, and public-form references are moved on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 3b15d2e7f20f94acc672ea07aea1a405b4ae393d is the one reviewed at 7ab66e78f…”
-
approved pull A private repository's records are named in full, and public-form references are moved on chadtmiller.com/knotless
“This pull rewrites an account's own space records to full-form references the first time knotless writes there for them,…”
-
approved pull A private repository's records are named by their URI in its space on chadtmiller.com/knotless
“This round I found nothing that has to change before merge. The pull names a private repository's records by their full…”
-
approved pull A private repository's records are named by their URI in its space on chadtmiller.com/knotless
“This pull names a private repository's records by their full URI in the space. It resolves references in the public form…”
-
approved pull Records in a space are read by their URI in full, as proposal 0016 names them on chadtmiller.com/knotless
“This adds aturi::{AtUri, SpaceRef} and moves the URI readers onto them: forge::parse_uri, RepoRef::did, closing keywords…”
-
approved pull knotless checks --ref takes a branch named bare on chadtmiller.com/knotless
“This makes checks::list turn a bare --ref name into a full ref before filtering. That covers the CLI and the MCP checks…”
-
approved pull deploy: knotless.dev's DNS is kept in the infra repository on chadtmiller.com/knotless
“This removes the Terraform from deploy/ (the .tf files, the tfvars example, the lock file and the Terraform lines in .gi…”
-
approved pull A push in the feed links to the commit it left, which outlives its branch on chadtmiller.com/knotless
“This adds to, the commit a push left its ref at, to dev.knotless.getFeed#pushed. The feed page now links "Commits →" to…”
-
approved pull runner-host: watch only named repositories, and take the image from another host on chadtmiller.com/knotless
“This adds three options to the runner host deploy: - KNOTLESS_RUNNER_DISCOVER set empty drops --discover. Left unset, --…”
-
approved pull Kept logs survive a failed write, and a trace reads whole on chadtmiller.com/knotless
“This pull puts a failed Logs::flush batch back ahead of the lines logged since, then caps it at PENDING_MAX and drops th…”
-
approved pull Spaces renew their credential before it runs out on chadtmiller.com/knotless
“Since my last review there is one new commit, 05a92c5. It makes the test in a_credential_held_past_its_end_is_renewed ca…”
-
commented on pull An operator reads the appview's logs without SSH on chadtmiller.com/knotless
“The batch is taken before the transaction. If the transaction, an insert or the commit fails, these lines are gone. Rest…”
-
asked for changes on pull An operator reads the appview's logs without SSH on chadtmiller.com/knotless
“The check and test runs for head 01bf4f7 were still running when I looked, so the coverage gate isn't confirmed. I re-re…”
-
approved pull The pages serve a blog at /blog, built from Markdown posts in blog/ on chadtmiller.com/knotless
“This adds an Astro site in blog-site/ that builds the Markdown posts in blog/ into static/blog. It has an index, a page…”
-
approved pull Spaces renew their credential before it runs out on chadtmiller.com/knotless
“Since my last review, the only change is f73ccd6. It boxes the Renew::renewed future in Space::held (space.rs) so the la…”
-
commented on pull An operator reads the appview's logs without SSH on chadtmiller.com/knotless
“take empties pending before the write. If the transaction, an insert or the commit fails, the batch is gone. Restore it…”
-
asked for changes on pull An operator reads the appview's logs without SSH on chadtmiller.com/knotless
“This round (head b611e67) merges main into the branch. The check and test runs for this head were still queued when I lo…”
-
approved pull A pull's card keeps a green square for a line added beside many removed on chadtmiller.com/knotless
“This caps the red squares at 4 when any line was added, so the added side keeps at least one green square. I checked the…”
-
approved pull Spaces renew their credential before it runs out on chadtmiller.com/knotless
“This puts a space's credential, or its owner's session, behind a mutex that all clones share, and renews it when it ends…”
-
commented on pull An operator reads the appview's logs without SSH on chadtmiller.com/knotless
“pending is emptied here before the write. If the transaction, an insert or the commit fails, the batch is lost, although…”
-
asked for changes on pull An operator reads the appview's logs without SSH on chadtmiller.com/knotless
“The compile error from round 1 is fixed: check (fmt and clippy) now passes. The test check was still queued when I looke…”
-
commented on pull A pull's card counts what it changes, and cards show when, not state on chadtmiller.com/knotless
“red can be 5 while added > 0, which leaves green with no square. Clamp it to 1..=4 when both sides are non-zero.”
-
asked for changes on pull A pull's card counts what it changes, and cards show when, not state on chadtmiller.com/knotless
“Size::squares is still unchanged from my last three reviews, so the request is still open. With added = 1 and removed =…”
-
commented on pull A pull's card counts what it changes, and cards show when, not state on chadtmiller.com/knotless
“With added = 1 and removed = 1000 this gives red = 5, so green gets no square. When both added and removed are > 0, clam…”
-
asked for changes on pull A pull's card counts what it changes, and cards show when, not state on chadtmiller.com/knotless
“Size::squares is unchanged from the last round, so my request is still open. With added = 1 and removed = 1000, red = ce…”
-
commented on pull A pull's card counts what it changes, and cards show when, not state on chadtmiller.com/knotless
“(5 - red, red) gives (0, 5) for 1 added and 1000 removed, so the added side shows no square. Clamp red to 1..=4 when bot…”
-
asked for changes on pull A pull's card counts what it changes, and cards show when, not state on chadtmiller.com/knotless
“The pull is much as before and the rest of it looks right. But Size::squares is still wrong, so my earlier request isn't…”
-
approved pull getTemplate reads the template from the mirror, as getFile does on chadtmiller.com/knotless
“The new commit changes only tests. In gateway.rs it drops the listWorkflows assertion from the private pages test, and t…”
-
commented on pull An operator reads the appview's logs without SSH on chadtmiller.com/knotless
“Compile error (E0308): asked is Vec<(&str, &str)> here but admin.logs takes &[(&str, String)] (moderation.rs:308). Push…”
-
asked for changes on pull An operator reads the appview's logs without SSH on chadtmiller.com/knotless
“This adds a SQLite-backed log keeper to serve (--logs). It also adds the operator-only getLogs query, knotless admin log…”
-
commented on pull A pull's card counts what it changes, and cards show when, not state on chadtmiller.com/knotless
“The doc says each side that changed anything shows at least one square, but this doesn't hold. With 1 added and 1000 rem…”
-
asked for changes on pull A pull's card counts what it changes, and cards show when, not state on chadtmiller.com/knotless
“The pull adds a stats row to a pull's social card: comments, reviews, files, +/− lines and five squares. The card's foot…”
-
approved pull Usage counts slow statements, why actions failed, and crawlers by agent on chadtmiller.com/knotless
“Both points from my last review are addressed in cdd886f.”
-
commented on pull getTemplate reads the template from the mirror, as getFile does on chadtmiller.com/knotless
“This comment describes the template assertion, but it now sits above the workflows comment. Move it down to just before…”
-
approved pull getTemplate reads the template from the mirror, as getFile does on chadtmiller.com/knotless
“The new commit changes only the private repository test. getTemplate no longer opens the repository as the member, so th…”