Monday, November 2
-
commented on pull The merge queue ejects failed pre-flights sooner and holds conflicts on chadtmiller.com/knotless
“An empty since makes every earlier failed run count as since queueing. If an item here can lack a queue record, prefer a…”
-
approved pull The merge queue ejects failed pre-flights sooner and holds conflicts on chadtmiller.com/knotless
“This pull makes four changes to the merge queue: - A pre-flight failure since the pull was queued now ejects it on whate…”
-
approved pull Following spaces with none to follow is covered by a test, not by chance on chadtmiller.com/knotless
“This adds a test change only. In the_steps_shared, the plain app (no index, built with App::build(.., None, ..)) now als…”
-
approved pull Workflows run on a schedule, at the default branch's tip on chadtmiller.com/knotless
“The only change since my last round is in the test a_schedule_runs_its_workflow. It now reads the run's log by fetching…”
-
asked for changes on pull A backfill asks a directory which accounts to read, and reads them from a mirror as STAR-lite on chadtmiller.com/knotless
“This round fixes layer_of, which now follows atproto's spec examples and has a test for them. It also orders maps inside…”
-
approved pull ci: The harness check keeps passing runs and fails network scans on grain.social/grain
“The only change since my last review is 64963a74, which removes space_invite from GROWING. The index's migration drops t…”
-
approved pull A queued pull says what it waits for and when it should land on chadtmiller.com/knotless
“The pull makes the merge queue say what each queued pull is waiting for and when it should land. I found nothing wrong i…”
-
approved pull A repository's commits, tags and releases as Atom feeds on chadtmiller.com/knotless
“Both points from my first review are done. Tag entries now take their id and link from the tree at the tag name, so two…”
-
approved pull serve: A login names its account by handle at once on grain.social/grain
“This pull makes the login callback track the account. It keeps the getSession handle only when that handle resolves back…”
-
asked for changes on pull A revision's files download as one tar.gz or zip archive on chadtmiller.com/knotless
“The stalled-client problem is fixed. The permit is now held for at most ten minutes (archive.rs:63-66). When the timeout…”
-
approved pull Workflows run on a schedule, at the default branch's tip on chadtmiller.com/knotless
“Since my last round the only change is a small refactor. learn now gets the last-read commit through a new known_schedul…”
-
approved pull ci: The harness check keeps passing runs and fails network scans on grain.social/grain
“This round fixes the queries the plans check found. It rewrites a few queries and adds -- scans: or -- sorts: notes to t…”
-
asked for changes on pull A backfill asks a directory which accounts to read, and reads them from a mirror as STAR-lite on chadtmiller.com/knotless
“The test helper now signs the DRISL-ordered encode(&commit), which is what I asked for. That should fix a_signed_reposit…”
-
approved pull Workflows run on a schedule, at the default branch's tip on chadtmiller.com/knotless
“This round resolves what I asked for earlier. I read only parts of the diff and the files below, not all of it, and I di…”
-
approved pull serve: A login names its account by handle at once on grain.social/grain
“Carried forward: the change this pull makes at 3c1bbc38a88040715f7134e3356d6574b68b1dbe is the one reviewed at 98e1b2468…”
-
approved pull A queued pull says what it waits for and when it should land on chadtmiller.com/knotless
“The pull makes the merge queue say what each queued pull is waiting for and when it should land. It adds typical, stage,…”
-
commented on pull A backfill asks a directory which accounts to read, and reads them from a mirror as STAR-lite on chadtmiller.com/knotless
“This signs cbor(&commit), the map in insertion order. checked verifies over unsigned(commit), which is in DRISL key orde…”
-
asked for changes on pull A backfill asks a directory which accounts to read, and reads them from a mirror as STAR-lite on chadtmiller.com/knotless
“This adds --directory and --mirror to the backfill, reads STAR-lite with MST-root verification, and checks commit signat…”
-
approved pull knotless-run: a feature branch's pulls start from its own warm caches on chadtmiller.com/knotless
“This gives a branch its own caches when its workflow names that branch in both on.push.refs and on.pull.base. The branch…”
-
approved pull Workflows run on a schedule, at the default branch's tip on chadtmiller.com/knotless
“This adds a schedule trigger. The runner learns each workflow's cron expressions from a push to the default branch and k…”
-
approved pull ci: The harness check keeps passing runs and fails network scans on grain.social/grain
“This moves the harness, e2e and rust workflows onto the shared steps. It also ports knotless's stored test runs, quarant…”
-
asked for changes on pull A queued pull says what it waits for and when it should land on chadtmiller.com/knotless
“The pull makes the merge queue say what each queued pull is waiting for and when it should land. The new head adds a com…”
-
approved pull serve: A login names its account by handle at once on grain.social/grain
“This pull makes the OAuth callback track the logged-in account. It writes the handle from getSession into repo.handle on…”
-
approved pull Task boxes tick at once, by their text too, and strike through what is done on chadtmiller.com/knotless
“This makes ticks instant: each tick is saved behind the boxes, one save at a time with the newest body last, and the pag…”
-
asked for changes on pull A queued pull says what it waits for and when it should land on chadtmiller.com/knotless
“The pull makes the merge queue say what each queued pull is waiting for and when it should land. I found nothing new in…”
-
asked for changes on pull A queued pull says what it waits for and when it should land on chadtmiller.com/knotless
“This pull makes the merge queue say what each queued pull is waiting for (running its checks, running them again, or rea…”
-
asked for changes on pull A repository's commits, tags and releases as Atom feeds on chadtmiller.com/knotless
“This adds commits.atom, tags.atom and releases.atom per repository. The feeds are hand-written XML, read as the viewer l…”
-
approved pull e2e runs its public and private flows side by side on chadtmiller.com/knotless
“The pull runs the public and private Playwright flows side by side, and the cargo and web builds side by side. I found n…”
-
approved pull A backfill reads each account whole from its PDS, checked, and only those that changed on chadtmiller.com/knotless
“Since my last review, the only change is one new commit, "The archive test reads a CAR whose first length never ends". I…”
-
approved pull A backfill never puts back what the feed has since changed or deleted on chadtmiller.com/knotless
“Since round 1 the pull has two small commits. as_of now takes &dyn Fn instead of a generic FnOnce, and the callers pass…”
-
commented on pull A revision's files download as one tar.gz or zip archive on chadtmiller.com/knotless
“The permit lasts as long as the client takes to read. A client that stalls leaves git blocked on the pipe and keeps its…”
-
asked for changes on pull A revision's files download as one tar.gz or zip archive on chadtmiller.com/knotless
“This adds /<owner>/<repo>/archive/<rev>.tar.gz and .zip, streamed from git archive. It reads as the viewer, so private r…”
-
approved pull Task items show their box in place of a list bullet on chadtmiller.com/knotless
“This adds one CSS rule to web/src/app.css. A .prose list item whose first child is a checkbox gets list-style:none. The…”
-
approved pull ci: The pages and grain-serve are checked together, end to end on grain.social/grain
“Since round 2 the pull has three changes. AGENTS.md and the cache comment are updated, which covers both points I left o…”
-
approved pull The author of an issue, pull or comment ticks its task boxes on the page on chadtmiller.com/knotless
“This lets the author of an issue, pull or comment tick its task boxes. A tick finds its item by counting task list items…”
-
approved pull A backfill reads each account whole from its PDS, checked, and only those that changed on chadtmiller.com/knotless
“This pull replaces the paged listRecords backfill with one getRepo CAR per account. It checks the commit's DID, its sign…”
-
approved pull ci: The pages and grain-serve are checked together, end to end on grain.social/grain
“The only change since round 1 is in the "editing a gallery" flow. It now reads the gallery back from her repo, then from…”
-
approved pull listSpaces leaves out deleted spaces, as the reference PDS does on chadtmiller.com/pds.js
“This still adds excludeDeleted to storage listSpaces. The memory, sqlite and Cloudflare adapters filter on it in the que…”
-
approved pull A backfill never puts back what the feed has since changed or deleted on chadtmiller.com/knotless
“This pull gives feed events a rev, adds the record_rev table, and adds put_as_of and delete_as_of, which skip a write wh…”
-
approved pull listSpaces leaves out deleted spaces, as the reference PDS does on chadtmiller.com/pds.js
“This adds an excludeDeleted option to storage listSpaces. The memory, sqlite and Cloudflare adapters apply it in the que…”