Monday, November 2
-
approved pull An organization's admins set its repositories' secrets on chadtmiller.com/knotless
“Round 2: the only new commits are a small test fix, "Bind the stranger's secret before putting it", and a merge of main.…”
-
asked for changes on pull An organization's admins change its repositories' settings on the pages on chadtmiller.com/knotless
“The code is unchanged from round 1 apart from merges of main and the secrets branch. My earlier read of the gate still h…”
-
commented on pull Deleting a ref deletes its record on chadtmiller.com/knotless
“This apply, and the refs count below, are not run by any test: both compact flow tests expect 0 dropped refs. Add a flow…”
-
asked for changes on pull Deleting a ref deletes its record on chadtmiller.com/knotless
“This pull makes a branch or tag delete remove its ref record (the claim still goes on the current generation) and starts…”
-
approved pull An organization's admins change its repositories' settings on the pages on chadtmiller.com/knotless
“This pull lets a joined organization admin use the Settings tab and make the pages' settings writes as the organization.…”
-
approved pull Releases keep their start across levels, and a notification mutes its thread on chadtmiller.com/knotless
“Since my last round there is one new commit, plus a merge of main. It changes two test-harness details. The shots stand-…”
-
approved pull An organization's admins set its repositories' secrets on chadtmiller.com/knotless
“This adds an optional owner to putSecret and deleteSecret. The new managed check accepts a named owner only when org_adm…”
-
approved pull A push makes only its own repository's mirrors stale, not the account's on chadtmiller.com/knotless
“This makes freshness two counters. One counts a DID's account-wide events. The other counts events for a single reposito…”
-
approved pull A mirror's sync reads its packs only when an object is missing on chadtmiller.com/knotless
“A mirror sync now calls the new Remote::heads, which reads the repository record and its refs but not the newest page of…”
-
approved pull A private repository's language shows at once on a list after its first count on chadtmiller.com/knotless
“Since my last review, the pull only merged main and added the Counted type alias for the PRIVATE_LANGUAGES map. Nothing…”
-
approved pull A run's layers that fail to go at first are removed again on chadtmiller.com/knotless
“Lease::drop now tries remove(&self.dir) up to three times, stopping at the first success. I read remove in caches.rs. It…”
-
commented on pull A repository's mirror syncs its refs from the index, not by listing its PDS on chadtmiller.com/knotless
“These three lines are about's doc comment, and they are still above live_ref. Move live_ref and its docs above them so t…”
-
asked for changes on pull A repository's mirror syncs its refs from the index, not by listing its PDS on chadtmiller.com/knotless
“The new commit only renames heard/heard_if to refresh_mirrors/refresh_if. That is fine. The one fix I asked for last rou…”
-
commented on pull A repository's mirror syncs its refs from the index, not by listing its PDS on chadtmiller.com/knotless
“These three lines are about's doc comment. The new live_ref was inserted between them and fn about, so about loses its d…”
-
approved pull A repository's mirror syncs its refs from the index, not by listing its PDS on chadtmiller.com/knotless
“This pull makes a public repository's mirror sync its record and live refs from a new live_ref index table. It does so o…”
-
approved pull A private repository's language shows at once on a list after its first count on chadtmiller.com/knotless
“This pull does two things. getActorRepos now answers a private repository's language from a process-wide cache once it h…”
-
approved pull A repository's ref records past the first page are read side by side on chadtmiller.com/knotless
“The only change since my last review is in ranges in remote.rs. It now collects the range starts into a Vec before zippi…”
-
approved pull A repository's ref records past the first page are read side by side on chadtmiller.com/knotless
“Nothing has changed in the code since my last review. The new commits are a merge of main, a changeset note, and a commi…”
-
approved pull A push is one sync of its mirrors, not one for each record it wrote on chadtmiller.com/knotless
“Since my last review, the pull has gained a merge of main and a commit that fixes the flaky mirror::tests::locks and the…”
-
approved pull A repository's ref records past the first page are read side by side on chadtmiller.com/knotless
“This pull makes Remote::refs read the first page as before. If that page is full, it reads the rest in up to eight key r…”
-
approved pull A profile's badges count each repository's merge batches in one query on chadtmiller.com/knotless
“This replaces the per-batch batch_states query with one query per repository. It builds a map of how many pulls each bat…”
-
approved pull Rarely reached branches share a line with what always runs on chadtmiller.com/knotless
“This pull rewrites three rarely-reached branches so each shares a line with code that always runs. I found no change in…”
-
approved pull A push is one sync of its mirrors, not one for each record it wrote on chadtmiller.com/knotless
“This makes knotless-serve count one touch per commit rev instead of one per Jetstream event, so a push's pack, claim and…”
-
approved pull Releases keep their start across levels, and a notification mutes its thread on chadtmiller.com/knotless
“Since my last round there is one new commit. It makes the shots' stand-in answer putSubscription for a signed-in viewer…”
-
approved pull A mirror's refs are set holding their lock until git is done on chadtmiller.com/knotless
“Since my last review the branch has only gained a "Merge main" commit. The settle task that holds the lock until git is…”
-
approved pull Releases keep their start across levels, and a notification mutes its thread on chadtmiller.com/knotless
“This pull keeps a repository's release start (releases_at) when the level moves between All activity and Releases. It ad…”
-
approved pull Coverage builds as many crates at once as a run's CPUs and memory allow on chadtmiller.com/knotless
“This sets CARGO_BUILD_JOBS in harness/cov.mjs to the smaller of the cgroup's CPU quota and its memory divided by 2.5 GiB…”
-
approved pull A mirror's refs are set holding their lock until git is done on chadtmiller.com/knotless
“This moves the ref update, commit-graph write and HEAD update in Mirror into a spawned settle task that holds the lock f…”
-
approved pull knotless-serve checks oplog values against their CIDs and syncs past a failing repo on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 0ac8fafa642b417cb61c9b87b944bda7b0441bbc is the one reviewed at 5b23fc6f3…”
-
approved pull knotless-serve checks oplog values against their CIDs and syncs past a failing repo on chadtmiller.com/knotless
“The coverage gap from last round is closed. At 5b23fc6 every check passes, including test. That run reports 100% functio…”
-
approved pull A mirror's repack runs aside, not in the way of its reads on chadtmiller.com/knotless
“The pull still does what my first review described. The only change since then is a merge of main and a new commit, "A t…”
-
commented on pull knotless-serve checks oplog values against their CIDs and syncs past a failing repo on chadtmiller.com/knotless
“This closure is the only uncovered code in the run, so the coverage gate fails. Add a test where the server returns the…”
-
asked for changes on pull knotless-serve checks oplog values against their CIDs and syncs past a failing repo on chadtmiller.com/knotless
“The merge conflict is resolved, and check (fmt and clippy) passes. The test check fails, though. Every test passes, but…”
-
approved pull What each notification says is found for its page alone on chadtmiller.com/knotless
“This wraps the notifications query in a subquery that does the filtering, sorting and LIMIT. The "also named" and line-c…”
-
approved pull A pull's checks are read from the index on its pull on chadtmiller.com/knotless
“This pull adds a check_pull_at index on (json_extract(value,'$.pull'), started_at, uri). When a pull filter is given, th…”
-
approved pull The coverage gate names lines only a function's test build has and misses on chadtmiller.com/knotless
“This makes harness/cov.mjs also name the lines missed by the instance with the most lines. That is the instance llvm-cov…”
-
asked for changes on pull knotless-serve checks oplog values against their CIDs and syncs past a failing repo on chadtmiller.com/knotless
“This pull checks private-repo oplog values against their CIDs. It also lets a sync read past a failing repo, takes a per…”
-
approved pull Who vouched for a commit is found in process, not a git each merged pull on chadtmiller.com/knotless
“The new commit fixes the type of people in vouched to Vec<(String, Option<Range>)>. That matches the Range = (String, St…”
-
asked for changes on pull Each sync of a mirror is logged, with its time reading records on chadtmiller.com/knotless
“This logs a mirror sync line, with duration_ms and the new records_ms, for each completed sync. It is at warn when slow.…”
-
approved pull Who vouched for a commit is found in process, not a git each merged pull on chadtmiller.com/knotless
“This replaces one git rev-list process per merged pull with an in-process gix walk (Objects::between). The mirror is ope…”