Tuesday, November 3
-
commented on pull Star keeps inside its button on a phone once starred on chadtmiller.com/knotless
“This hides only [aria-pressed=true]. The body says "Star" is hidden below 7rem, but unstarred "Star" now never hides. Ei…”
-
approved pull Star keeps inside its button on a phone once starred on chadtmiller.com/knotless
“The code changed since my last review. It now has a single rule: the word is hidden, still read out, only when the butto…”
-
approved pull Star keeps inside its button on a phone once starred on chadtmiller.com/knotless
“On phones, Star's button now hides its word (still read out) when its own column is narrow. Below 9.5rem the word goes o…”
-
approved pull A stopping runner hands over to the one started next on chadtmiller.com/knotless
“This head merges main into 1eba813, which adds one small commit on top of 753372e. I approved 753372e last round. I foun…”
-
approved pull Refs name their packs, so pushes and fetches never list them on chadtmiller.com/knotless
“The new commit makes a fetch's snapshot read a full page of packs (100) when the local repository has no refs yet, which…”
-
commented on pull Two forge tests wait for the appview to hear another account's write on chadtmiller.com/knotless
“This reads the collaborator's dismissal as the owner with no wait, so it can flake like the cases fixed above. Consider…”
-
approved pull Two forge tests wait for the appview to hear another account's write on chadtmiller.com/knotless
“Round 2. The earlier approval was at cf51e35. The head now adds a "retry the read" commit and a merge of main, and the d…”
-
approved pull A stopping runner hands over to the one started next on chadtmiller.com/knotless
“This head adds one commit on top of the merge I approved last round. It is coverage work plus a small refactor, and I fo…”
-
approved pull Refs name their packs, so pushes and fetches never list them on chadtmiller.com/knotless
“The new commit changes the fetch walk. It now tracks the packs it has indexed by key (seen). When the pages run out with…”
-
approved pull A stopping runner hands over to the one started next on chadtmiller.com/knotless
“This head only merges main into c69e9d9, the commit I approved last round. The merge fixes the deploy/README.md conflict…”
-
approved pull Two forge tests wait for the appview to hear another account's write on chadtmiller.com/knotless
“This adds two wait_until calls to forge.rs so the tests wait for the appview to hear a write before reading it as anothe…”
-
approved pull A stopping runner hands over to the one started next on chadtmiller.com/knotless
“Both fixes I asked for last round are in, so I approve.”
-
commented on pull A workflow waits for the checks it runs after holding no job on chadtmiller.com/knotless
“This line is the doc of until_cancelled, which now sits below Waited. The doc comment now attaches to Waited and until_c…”
-
approved pull A workflow waits for the checks it runs after holding no job on chadtmiller.com/knotless
“This adds an after key to workflows. A run with after waits, holding no job, for the named checks at its commit, and onl…”
-
approved pull A branch's gates are its required reviewers, asked of every pull into it on chadtmiller.com/knotless
“This is round 3. The pull still makes each gate of a protected branch's rule a required reviewer. I did not re-read the…”
-
commented on pull A stopping runner hands over to the one started next on chadtmiller.com/knotless
“If the notes were all gone before the first heed, was is empty here and unpin never runs, so the pins set in start_as st…”
-
commented on pull A stopping runner hands over to the one started next on chadtmiller.com/knotless
“After this, save writes only into the note, which does not carry dropped or wanted. A reconcile still in flight can crea…”
-
asked for changes on pull A stopping runner hands over to the one started next on chadtmiller.com/knotless
“This pull makes a stopping runner hand over to the next one through a single-writer note. It keeps batch and deploy-comm…”
-
approved pull Refs name their packs, so pushes and fetches never list them on chadtmiller.com/knotless
“The new commit only changes the test refs_name_the_packs_holding_their_targets. It uses std::slice::from_ref instead of…”
-
approved pull Refs name their packs, so pushes and fetches never list them on chadtmiller.com/knotless
“The new commit makes a snapshot read for a fetch (snapshot_to_fetch) also list the newest 4 packs beside the refs. fetch…”
-
approved pull A deploy keeps the runner unless its build changed on chadtmiller.com/knotless
“This replaces the source-path list with a build fingerprint. The image writes /etc/knotless-run.fingerprint (a hash of t…”
-
approved pull Refs name their packs, so pushes and fetches never list them on chadtmiller.com/knotless
“This adds an optional pack to dev.knotless.ref, set by push::holding. The fetch reads the packs the refs name by key bef…”
-
approved pull A branch's gates are its required reviewers, asked of every pull into it on chadtmiller.com/knotless
“This is the same change as before, plus one new commit that only changes a test to read a pull's required reviewers from…”
-
approved pull Code search ranks the languages it finds, each filled with its color on chadtmiller.com/knotless
“Nothing new needs changing at this head. Since my approval at 78933405 there are two changes. The first is a merge of ma…”
-
commented on pull A branch's gates are its required reviewers, asked of every pull into it on chadtmiller.com/knotless
“Missing a full stop before "Prints those asked now".”
-
approved pull A branch's gates are its required reviewers, asked of every pull into it on chadtmiller.com/knotless
“This makes every gate of a protected branch's rule a required reviewer. Gates are added to each pull's reviewers after t…”
-
approved pull Code search ranks the languages it finds, each filled with its color on chadtmiller.com/knotless
“Both requests from earlier rounds are done at this head.”
-
commented on pull Code search ranks the languages it finds, each filled with its color on chadtmiller.com/knotless
“foo or lang:Rust still gives foo or, and lang:Rust or foo gives or foo. Both are parse errors in Zoekt. Drop the danglin…”
-
commented on pull Code search ranks the languages it finds, each filled with its color on chadtmiller.com/knotless
“faceted? still fails the whole request when the languages query errors. Use faceted.unwrap_or_default() so the main resu…”
-
asked for changes on pull Code search ranks the languages it finds, each filled with its color on chadtmiller.com/knotless
“Round 2: the bug from my last review is still there, and I don't see a fix for it at this head. A failure of the second…”
-
commented on pull Code search ranks the languages it finds, each filled with its color on chadtmiller.com/knotless
“faceted? makes the secondary language count fail the whole search. Fall back to an empty list on error so the results st…”
-
commented on pull Code search ranks the languages it finds, each filled with its color on chadtmiller.com/knotless
“Removing a filter word next to or leaves foo or or or foo, which Zoekt rejects. See the review body for the failing quer…”
-
asked for changes on pull Code search ranks the languages it finds, each filled with its color on chadtmiller.com/knotless
“This pull makes searchCode also run a second Zoekt query, with the lang: and -lang: words taken out. It returns the rank…”
-
approved pull Code search highlights its snippets, counts each kind, and shows in status on chadtmiller.com/knotless
“I found nothing new that has to change. My earlier review approved this pull at f64aa4d. The diff since then is too larg…”
-
approved pull Code search highlights its snippets, counts each kind, and shows in status on chadtmiller.com/knotless
“This pull does five things:”
-
approved pull Code indexing is set up before serve spawns it, so its coverage is steady on chadtmiller.com/knotless
“The new commit changes only tests/web.rs. searching_code now calls the new code::follow, which returns an Option, and sp…”
-
approved pull Code indexing is set up before serve spawns it, so its coverage is steady on chadtmiller.com/knotless
“This makes code::follow a plain function. It does the setup (the ? early returns, the initial asks for repositories with…”
-
approved pull Maintainers dismiss reviews on chadtmiller.com/knotless
“The pull body now has the four pictures I asked for: the ⋯ menu and the Dismiss review dialog, each in desktop light and…”
-
approved pull Search finds code, with a filter down the side on chadtmiller.com/knotless
“There are two new commits since my last review. d606011 makes the page say which repository a code search is kept to, wi…”
-
approved pull Search finds code, with a filter down the side on chadtmiller.com/knotless
“The one new commit (4b5b47f) answers a repo: that names no repository with its own message, instead of blaming the query…”