Saturday, November 7
-
approved pull A release not made says why, rather than always that it exists on chadtmiller.com/knotless
“Carried forward: the change this pull makes at d422bbcf7b9c1c8e749ab6ddff6dd49df48d4bb2 is the one reviewed at 40a871621…”
-
approved pull knotless-serve answers Cargo's registry for a repository's crates on chadtmiller.com/knotless
“This round adds three changes on top of the commit I reviewed: a merge of the base branch, a wider description limit, an…”
-
approved pull A release can be yanked, leaving it to read but no one's latest on chadtmiller.com/knotless
“My earlier request is still done: indexed_collections() lists RELEASE_YANK, and a_backfill_reads_yanks covers it. I did…”
-
commented on pull knotless-serve answers Cargo's registry for a repository's crates on chadtmiller.com/knotless
“The release exists after this line, but a failure in the get_record or index.put steps below returns a 502, and a retry…”
-
commented on pull knotless-serve answers Cargo's registry for a repository's crates on chadtmiller.com/knotless
“size comes from the tar header, so this can allocate up to 1 GiB for a Cargo.toml. A tighter cap (e.g. 1 MiB) would do.”
-
approved pull knotless-serve answers Cargo's registry for a repository's crates on chadtmiller.com/knotless
“This adds a per-repository Cargo registry to knotless-serve (sparse index, download, publish, yank and its undo, search)…”
-
approved pull A release not made says why, rather than always that it exists on chadtmiller.com/knotless
“This changes Target::create so a failed release write says published already only when the release record can be read ba…”
-
approved pull just queue-stats counts the ejections its runners write on chadtmiller.com/knotless
“This makes just queue-stats read queue records from the repository's runners as well as the owner. It keeps only records…”
-
approved pull Push registers with registerPush, falling back on servers without it on grain.social/grain-android
“Carried forward: the change this pull makes at ba54bcbcdcb13867f30037f3d7d89b1c696e58c8 is the one reviewed at f901c0677…”
-
approved pull A release can be yanked, leaving it to read but no one's latest on chadtmiller.com/knotless
“My earlier request is still done: indexed_collections() lists RELEASE_YANK, and a_backfill_reads_yanks covers it. Since…”
-
approved pull A release can be yanked, leaving it to read but no one's latest on chadtmiller.com/knotless
“My earlier request is still done: indexed_collections() lists RELEASE_YANK, and a_backfill_reads_yanks covers it. Since…”
-
approved pull A release can be yanked, leaving it to read but no one's latest on chadtmiller.com/knotless
“The earlier request is done. indexed_collections() in crates/knotless-serve/src/lib.rs now lists nsid::RELEASE_YANK, and…”
-
approved pull just queue-stats counts the ejections its runners write on chadtmiller.com/knotless
“This makes just queue-stats read queue records from the repository's runners as well as the owner. It keeps only records…”
-
approved pull The merge queue is off until a branch's rule turns it on on chadtmiller.com/knotless
“This round touches two Svelte files. The empty queue page now links to branch settings for the repository's owner or an…”
-
commented on pull A release can be yanked, leaving it to read but no one's latest on chadtmiller.com/knotless
“The index stores yanks here, but indexed_collections() in crates/knotless-serve/src/lib.rs doesn't list RELEASE_YANK, so…”
-
asked for changes on pull A release can be yanked, leaving it to read but no one's latest on chadtmiller.com/knotless
“This adds dev.knotless.releaseYank, a second record under the release's own key. It adds release yank [--undo] and the r…”
-
approved pull The merge queue is off until a branch's rule turns it on on chadtmiller.com/knotless
“This round adds the last change you described: the pages link to the queue while a pull waits there, even after the rule…”
-
approved pull Builds older than the server's minimum ask to be updated on grain.social/grain-android
“Carried forward: the change this pull makes at cfedcf02909be3783d994e29f5d34e1a0d519e73 is the one reviewed at 436e52845…”
-
approved pull Push registers with registerPush, falling back on servers without it on grain.social/grain-android
“Carried forward: the change this pull makes at f901c0677485fcd4975cf10247b11c8fa385b3d9 is the one reviewed at e4fac497d…”
-
approved pull Android releases as 0.7.0 on grain.social/grain-android
“This bumps versionCode 13→14 and versionName 0.6.0→0.7.0 in app/build.gradle.kts, which is what RELEASE.md asks for. It…”
-
approved pull The pages, the harness and the docs site are formatted by oxfmt on chadtmiller.com/knotless
“Carried forward: the change this pull makes at ff40888fe06c122141db3765f15f1a2ca16d4884 is the one reviewed at 49866ba30…”
-
approved pull The iOS app's diffs load after being scrolled past on chadtmiller.com/knotless
“This fixes the iOS Files changed view. A cancelled getPullDiff read, from a row scrolling off screen or a file collapsin…”
-
approved pull The merge queue is off until a branch's rule turns it on on chadtmiller.com/knotless
“This round has a test fix and a merge of main. Since my last review, a_merge_queue_waits_for_its_gate now sets --queue (…”
-
approved pull A connector whose login has ended has its user sign in again on chadtmiller.com/knotless
“The only change since my approval is the last commit, which makes the dead-login test edit the stored session by its rea…”
-
approved pull The pages, the harness and the docs site are formatted by oxfmt on chadtmiller.com/knotless
“This adds oxfmt for web/, harness/ and docs-site/, with the settings in .oxfmtrc.json. It adds a format step to the web…”
-
approved pull The merge queue is off until a branch's rule turns it on on chadtmiller.com/knotless
“This round adds the keeper change I flagged last time. knotless-agent keep now skips an ejected pull when queue::takes i…”
-
approved pull A confidential client's OAuth session lasts as on the reference PDS on chadtmiller.com/pds.js
“This gives private_key_jwt clients a 2-year session limit and a 3-month idle limit on refresh. Public clients keep 2 wee…”
-
approved pull A connector whose login has ended has its user sign in again on chadtmiller.com/knotless
“This pull makes the server treat a connector as signed out once its PDS refuses to refresh the stored session. bearer an…”
-
approved pull The merge queue is off until a branch's rule turns it on on chadtmiller.com/knotless
“This makes the merge queue opt-in per branch. enqueue now refuses a pull unless takes is true, meaning the branch under…”
-
approved pull A merge commit's page shows what the merge brought in on chadtmiller.com/knotless
“This adds --diff-merges=first-parent to the one git show call behind getCommit and the commit page. A merge now shows wh…”
Friday, November 6
-
approved pull An account with no handle is looked up again after ten minutes on chadtmiller.com/knotless
“This keeps a "no handle" row for ten minutes instead of a day, then looks it up again behind the page, as a found handle…”
-
approved pull The marketing images and listing words live in the repository on chadtmiller.com/knotless
“This adds marketing/: the ATStore listing fields and images, the Bluesky banner, the HTML pages that draw the hero and b…”
-
approved pull The iOS app's next TestFlight build is 4, and its delete stops if nothing goes on chadtmiller.com/knotless
“This sets the iOS build number to 4 and makes the delete-data loop stop with an error when a step deletes nothing and is…”
-
commented on pull The iOS app reports, blocks and deletes an account's data, as the pages do on chadtmiller.com/knotless
“This loop has no guard against a step that deletes nothing without finishing. Consider breaking with a failure when step…”
-
approved pull The iOS app reports, blocks and deletes an account's data, as the pages do on chadtmiller.com/knotless
“This adds reporting, blocking and deleting account data to the iOS app. Reporting is on profiles, repositories, pulls, i…”
-
approved pull The iOS app's code explorer shows folders filled on chadtmiller.com/knotless
“This swaps the folder icon in the iOS code explorer to Octicons' file-directory-fill. It adds the new imageset and delet…”
-
approved pull The iOS app's sign-in suggests handles as they're typed on chadtmiller.com/knotless
“This adds handle suggestions to the iOS sign-in. After 150ms without typing, and from two letters, the app asks the type…”
-
approved pull The iOS app's sign-in screen is the tilde over a handle and a button on chadtmiller.com/knotless
“This replaces the iOS sign-in form with a centred tilde mark, a handle field, a Sign in button and a terms/privacy line.…”
-
approved pull The iOS app's next TestFlight build is 3 on chadtmiller.com/knotless
“This changes CURRENT_PROJECT_VERSION in ios/project.yml from "2" to "3", which is the per-upload bump that ios/README.md…”
-
approved pull The iOS app's diff keeps each line on one row, scrolling sideways on chadtmiller.com/knotless
“This replaces the per-row DiffLine with DiffLines. It has a fixed number/marker column and a horizontally scrolling code…”