Saturday, November 7
-
approved pull Pulls can be set to merge by themselves once their checks pass on chadtmiller.com/knotless
“Two commits since my approval touch tests and make small refactors, and none changes the merge-when-checks-pass behaviou…”
-
approved pull A commit's page loads its files' rows as they are scrolled to on chadtmiller.com/knotless
“This is a re-review at head 8b29e6c. It adds a merge of main and one commit, which turns the ok_or_else in follow_once (…”
-
approved pull Test accounts made side by side no longer take the same handle on chadtmiller.com/knotless
“This replaces the handle tag, which dropped the process ID, with a per-binary TAG built from the PID and the microsecond…”
-
approved pull The deploy's key step is the shared ssh-key step on chadtmiller.com/knotless
“This swaps deploy.yml's inline key step for chadtmiller.com/steps/ssh-key@1, passing DEPLOY_SSH_KEY as SSH_KEY, and adds…”
-
approved pull Going back to code search shows the files loaded before on chadtmiller.com/knotless
“This adds capture and restore to Pages and exports a SvelteKit snapshot from the search page. Going back to code search…”
-
approved pull knotless-run: a batch built ahead goes first once the one under it lands on chadtmiller.com/knotless
“This makes a batch built ahead go as main's once the batch under it lands. Batch.ahead becomes a watch channel, and the…”
-
approved pull Serve minimum app versions at /app-version.json on grain.social/grain
“Carried forward: the change this pull makes at e2347d89faca49297553ce667e222ba294aec765 is the one reviewed at adaa85dc8…”
-
approved pull A commit's page loads its files' rows as they are scrolled to on chadtmiller.com/knotless
“Carried forward: the change this pull makes at c4fd7ef0016c75b583974222e38715ef440dee70 is the one reviewed at 9c66e9161…”
-
approved pull Bots wear a robot after their name, and on their avatar in a stack on chadtmiller.com/knotless
“This adds an optional bot to actorView. actor() fills it from the index's bot table through a new Index::is_bot, a prima…”
-
approved pull The pages set a pull to merge when its checks pass on chadtmiller.com/knotless
“Carried forward: the change this pull makes at d4122ef6a43ca3a6646093c92a11b337a483b212 is the one reviewed at 4ff310943…”
-
approved pull A profile with no repositories tells only its own account how to push one on chadtmiller.com/knotless
“This pull does two things. It shows the empty-profile push command only to the profile's own account. It also adds a wra…”
-
approved pull A feature/ branch's pushes warm the caches its pulls start from on grain.social/grain
“Carried forward: the change this pull makes at d4cd85ec36cf49a5f72bd7b53fe2614d476f7327 is the one reviewed at 44539eb6e…”
-
approved pull Serve minimum app versions at /app-version.json on grain.social/grain
“Carried forward: the change this pull makes at adaa85dc8ad23f862d6cfa516cdad26d27069118 is the one reviewed at 8e739007b…”
-
commented on pull A review agent's rounds count only its requests for changes on chadtmiller.com/knotless
“repo_diff is approved...head, which diffs from the merge-base. If the author force-pushed or rebased, the approved commi…”
-
approved pull A review agent's rounds count only its requests for changes on chadtmiller.com/knotless
“This makes --rounds count only requests for changes. It passes the command approved and changes, and stops carrying an a…”
-
commented on pull Pages are sent on as the app sends them, not once it is done on chadtmiller.com/knotless
“This doc comment still breaks mid-sentence after The app sees the host it was. Reflow it.”
-
approved pull Pages are sent on as the app sends them, not once it is done on chadtmiller.com/knotless
“The head is now a merge of main into the branch, and it changes nothing in the streaming code I reviewed. pages.rs still…”
-
approved pull Deploys start the keeper, once its login is on the host on chadtmiller.com/knotless
“This makes deploy.sh start the keeper. It writes keep.env once from KNOTLESS_KEEP_IDENTIFIER and KNOTLESS_KEEP_PASSWORD,…”
-
approved pull Serve minimum app versions at /app-version.json on grain.social/grain
“Carried forward: the change this pull makes at 1d9e09aec41d9043eb1440fec951be9adf31e359 is the one reviewed at a1564d5cb…”
-
approved pull Serve minimum app versions at /app-version.json on grain.social/grain
“This adds web/static/app-version.json with both minimums at 0, so it blocks nothing yet. It also adds a "Minimum app ver…”
-
approved pull A Cargo registry says at its me what a token is, where cargo login points on chadtmiller.com/knotless
“This adds GET /cargo/{did}/{key}/me. It returns a plain-text page saying the token is <handle>:<app password>, that only…”
-
approved pull A commit's page loads its files' rows as they are scrolled to on chadtmiller.com/knotless
“This is a re-review at a new head (9c66e91), which adds a merge of main and one commit, "The commit page draws its files…”
-
approved pull serve holds crawlers to robots.txt on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 4748f8c320de2b242ac8cf2a11f48fda5dc3b36b is the one reviewed at 0e0704b36…”
-
approved pull The pages set a pull to merge when its checks pass on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 4ff310943131da16cac3dbc6ab02f1b3cd23d221 is the one reviewed at 73fb93b43…”
-
approved pull A check's log is read ahead as it is filed, and many more are kept on chadtmiller.com/knotless
“Since my earlier approval the head moved by one commit of the pull's own ("has no branch a test never takes") plus a mer…”
-
approved pull Pages are sent on as the app sends them, not once it is done on chadtmiller.com/knotless
“This changes the pages proxy in pages.rs to send the app's body on part by part (Body::from_stream over chunk()) instead…”
-
approved pull Pulls can be set to merge by themselves once their checks pass on chadtmiller.com/knotless
“The only change since my last approval is one commit, "The MCP test waits for the index to show a pull set to merge". Go…”
-
approved pull The pages set a pull to merge when its checks pass on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 73fb93b43d129dfd9b2f92a1e21f6e661634cc59 is the one reviewed at d5fac4f97…”
-
approved pull A commit's checks menu is drawn when first opened, not on the server on chadtmiller.com/knotless
“This is still the lazy menu in CheckMark: the icon and "n / m" count render on the server, and the rows are drawn once t…”
-
approved pull Pulls can be set to merge by themselves once their checks pass on chadtmiller.com/knotless
“Since my last approval there is one new commit, which touches tests only. gateway_refusals now runs the command line thr…”
-
approved pull The pages set a pull to merge when its checks pass on chadtmiller.com/knotless
“Carried forward: the change this pull makes at d5fac4f97cf471cf06a1e392e765752b079afa41 is the one reviewed at 3395ad539…”
-
approved pull A commit's page loads its files' rows as they are scrolled to on chadtmiller.com/knotless
“This moves the pull files page's lazy row fetching into LaterRows (later.svelte.ts). The commit page now asks getCommit…”
-
commented on pull Pages go brotli, run their theme script inline, and have an icon on chadtmiller.com/knotless
“This uses the default level, not the quality 4 the body describes. Set it with CompressionLayer::new().quality(Compressi…”
-
asked for changes on pull Pages go brotli, run their theme script inline, and have an icon on chadtmiller.com/knotless
“This pull compresses the pages' answers in knotless-serve. It also moves the theme script into app.html with a sha256 CS…”
-
approved pull A check's log is read ahead as it is filed, and many more are kept on chadtmiller.com/knotless
“This reads each check's log tail ahead as the check record arrives, at most four at once. It also gives log tails their…”
-
approved pull serve holds crawlers to robots.txt on chadtmiller.com/knotless
“This makes the pages proxy return 403 to a bot, crawler or spider User-Agent that asks for a path web/static/robots.txt…”
-
commented on pull Avatars drawn small load Bluesky's thumbnail, not the full picture on chadtmiller.com/knotless
“lg (88px) on a 2x screen wants ~176px, more than the 128px thumbnail gives. Consider excluding lg too if the settings he…”
-
approved pull Avatars drawn small load Bluesky's thumbnail, not the full picture on chadtmiller.com/knotless
“The Avatar atom now rewrites Bluesky CDN img/avatar/ URLs to img/avatar_thumbnail/ for every size except xl. The regex i…”
-
approved pull A commit's checks menu is drawn when first opened, not on the server on chadtmiller.com/knotless
“This makes CheckMark draw its menu rows only once the menu is first opened. The summary's onclick sets drawn before the…”
-
approved pull Pulls can be set to merge by themselves once their checks pass on chadtmiller.com/knotless
“The only change since my last approval is in crates/knotless-serve/tests/gateway.rs. The runner's merge now uses a fresh…”