~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/hud

A remote MCP server that shows atproto records as interactive UI inside MCP Apps hosts

0
0

Profiles have Follow, and knotless's page is another's profile

Open
Open chadtmiller.com wants to merge into main from chadtmiller.com/hud:profiles/follow

Profiles on Bluesky, Grain and knotless get a Follow button, and someone else's knotless page is now their profile, as on knotless.dev, rather than a copy of your own Home. Your own knotless page stays Home.

Claude Opus 5.5 · medium

What changes

Follow. Bluesky's page and profile tile, Grain's page, and knotless's page and profile tile have Follow, an Action creating app.bsky.graph.follow, social.grain.graph.follow or dev.knotless.follow with the account as subject. It starts as Following where viewer.following names the follow already made, and a click undoes it. It is drawn only on someone else's profile (others). Sign-in now asks to write those three collections, as the scope is built from what the bundled views write.

knotless's page. On one's own account it is Home as before (My work, Favorites, Recent). On anyone else's it is their profile: avatar, name, handle, bio, pronouns, followers and following with Follow, links, organizations (getProfile), 4 of their repositories as cards (getActorRepos), links to all repositories, Stars and Activity, and Recent. The old "Work" rows on another's page are gone.

knotless-profile (the getProfile tile a repository's owner opens) draws the same profile, joining getActorRepos and getFeed.

Page joins by side. An app page's query join may say "mine": true (run on one's own page alone) or "mine": false (another's alone); without it, it runs on both. describe_app runs only the side's joins, and the cap of 4 query joins holds per side. knotless's page joins issues, pulls and stars on one's own, profile and repos on another's, and recent on both. Only app pages (bundled alone) take mine; a query view's join refuses it.

Gallery. harness/gallery/record.mjs --only=<id,…> records those entries again and keeps the rest. knotless-app and knotless-profile were recorded again; the made-up answers, which the script always rewrites, picked up the current views' documents.

Why

Home is for the person it belongs to: on someone else's account its work rows said little, and knotless.dev shows a profile there. Joining both Home's and a profile's queries on every page would have run 6 joins over the cap of 4 and fetched what the page does not draw, so each side runs only its own.

How it was checked

  • just check passes, at 100% of lines and functions.
  • New tests: page_joins_run_on_a_side (parsing, the per-side cap, a non-boolean mine, mine refused in a query view), describe_app signed in running Home's joins on one's own page and the profile's on bob's, and knotless_has_its_own_page drawing both sides.
  • Against the live knotless appview through a local hud serve: another's page ran profile, repos and recent only.
  • The gallery (just gallery) looked at desktop light and phone dark: Bluesky's and Grain's Follow, knotless's page and profile tile.

Shortcomings

  • Follow is drawn as every Action is (small muted words, a pill on hover); it reads more like a label than a button on a profile. A stronger style would be a new Action style in the catalog, the web renderer and iOS.
  • The followers count does not move when you follow.
  • The 4 repositories are in the order getActorRepos answers, not most recently pushed as knotless.dev sorts them; knotless.dev's activity heatmap and badges have no component here and are left out.
  • knotless-app and knotless-profile draw the same profile, written out twice.
  • The gallery's answers are recorded signed out, so it shows the profile side and never Home.
  • No just look pictures, and the change was not tried in the iOS app.

Review

Start at views/knotless-app.json and the mine handling in view.rs (Top, query_join, the per-side cap in joins) and describe_app_tool in tools.rs.

Approved

This adds Follow to the Bluesky, Grain and knotless profiles. It makes someone else's knotless page their profile and keeps your own as Home. App-page query joins can now say mine: true or mine: false, so each side runs only its own joins under the cap of 4 per side.

I found nothing that must change. I read the mine handling in view.rs, describe_app in tools.rs, the scope and OAuth test edits, the record.mjs change, the Follow blocks in the bsky/grain/knotless-profile views, and the docs.

  • The per-side cap counts joins that are mine or unset on each side, and mine is accepted only on app pages.
  • The describe_app filter treats a missing mine as running on both sides.
  • The OAuth test now uses app.bsky.graph.block as its "collection no view writes", which keeps that check meaningful.
  • The new tests cover both sides, the cap, a non-boolean mine, and mine in a query view.

I did not read views/knotless-app.json or harness/gallery/answers.json. The first is a large view rewrite and the second is about 6,700 lines of recorded data, and I read neither. The profile tree in knotless-app.json should match knotless-profile.json, which I did read. The knotless_has_its_own_page test checks both sides of it, and the pull says just check passed.

Approved

This pull adds Follow to the Bluesky, Grain and knotless profile views. It also gives someone else's knotless page the profile layout, through a per-side mine flag on app-page query joins.

I read the Rust (view.rs, tools.rs, scope.rs, oauth/tests.rs) and the Follow additions in bsky-app, grain-app and knotless-profile. I did not read knotless-app.json, bsky-profile.json, grain-app's other parts, the docs, or the 6.7k-line answers.json. The gallery file is recorded data.

  • Parsing and cap: mine is accepted only in app-page joins and must be a boolean. The cap of 4 holds per side, since each side counts the joins whose mine is not the opposite. page_joins_run_on_a_side tests these cases.
  • Running: describe_app filters joins with is_none_or(|m| m == mine), so a join with no mine runs on both sides.
  • Scope: the three follow collections are now written. The tests moved to app.bsky.graph.block as the collection no view writes.
  • Checks: web and lexicons passed as skipped, and check, test, docs, e2e and e2e-spaces were still queued when I looked. I am approving on the diff, and those checks decide the rest.