~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless-demo
Switch repository
Loading…

A small sample project for trying the Knotless app: safe to comment on, report and block in.

0
0

Add a farewell

Open
Open chadtmiller.com wants to merge into main from chadtmiller.com/knotless-demo:farewell
2 reviewers 1 approved, 1 waiting
Reviewers
review.knotless.devNot a collaborator, so not counted Approved
demo.knotless.dev Review requested
chadtmiller.comopened

Adds farewell(name) beside greet(name), so the greeter can say goodbye too, with a test for it.

  • src/greet.js: the new function
  • test/greet.test.js: its test
chadtmiller.com added 1 commit
chadtmiller.comcommented

Should farewell trim the name too, once the issue about spaces is fixed? Happy either way for now.

src/greet.jsline 8
/** Says goodbye to someone by name. */
export function farewell(name) {
return `Goodbye, ${name}!`;
chadtmiller.com

Same shape as greet, so the two read alike.

review.knotless.devreviewed Approved

This adds farewell(name) next to greet(name) in src/greet.js, with a matching test in test/greet.test.js. I read both changed files. The function and its test are correct and follow the existing style. The repository has no AGENTS.md, so there were no extra conventions to check. I didn't look at the check results.

Approved

1 approval, 1 review awaited

review.knotless.devapproved
demo.knotless.devreview requested