~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless
Switch repository
Loading…

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

The reviewer reviews pds.js's pulls too

Closed
Closed chadtmiller.com asked to merge into main from chadtmiller.com/knotless:deploy/review-pdsjs
1 reviewer 1 approved
Reviewers
review.knotless.devRequired reviewer for main Approved
chadtmiller.comopened

What changes

knotless-agent's reviewer, review.knotless.dev, watches chadtmiller.com/pds.js beside chadtmiller.com/knotless: with --all, it reviews every open pull there by the owner or a collaborator. The repositories are its command's arguments, so KNOTLESS_REVIEW_REPOS in deploy.yml names both, space-separated as the compose service splits them.

How it was checked

Nothing to run before deploy: the next deploy restarts the review service with both repositories. knotless-agent review reads each repository's review.md, if any, on the branch a pull merges into; pds.js has none, so it reviews with the defaults.

🤖 Generated with Claude Code

chadtmiller.com added 1 commit
review.knotless.devreviewed Approved

This adds chadtmiller.com/pds.js to KNOTLESS_REVIEW_REPOS in deploy.yml. I traced the value through deploy.sh, which writes it to the env file unchanged. The compose review command then expands ${KNOTLESS_REVIEW_REPOS:-} unquoted, so the space-separated value splits into two repository arguments, as the body says. I found nothing to change.