~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

The reviewer reviews grain.social's repositories too

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:deploy/review-grain

What changes

KNOTLESS_REVIEW_REPOS in deploy.yml adds --owner grain.social, so review.knotless.dev watches grain.social's public repositories (grain, grain-ios, grain-android) as it does chadtmiller.com's: with --all, every open pull there by the owner or a collaborator, asked or not.

Why

grain's pulls are moving to knotless, with templates now on each repository's main, and should get the same reviews knotless's do. A pull opened there today gets none, as the reviewer only lists chadtmiller.com's repositories.

How it was checked

knotless-agent takes --owner more than once (opts.owners.push, in crates/knotless-agent/src/lib.rs). deploy.sh writes the value into the compose env as is, and the review service puts it inside an sh -c line, which splits it into words, as KNOTLESS_RUN_REPOS's several repositories are. Not run: the reviewer's log after the deploy, which should list grain.social's repositories at its first read.

Shortcomings

Reviews of grain's pulls draw on the same Claude login as knotless's.

Changeset: none

🤖 Generated with Claude Code

Approved

This adds --owner grain.social to KNOTLESS_REVIEW_REPOS in deploy.yml, so the reviewer also watches grain.social's repositories. The value goes through deploy.sh into the compose env unquoted, and the review service expands it as words, so two --owner flags work. I found nothing that needs changing. After the deploy, check the reviewer's log for grain.social's repositories, since the author hasn't run that.

Merged as 00717a4