~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

Review headers keep the name beside the avatar, and fields stop zooming on a phone

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:web/review-head-and-zoom

What changes

Review headers on a phone. A review's header lets its verdict wrap to a second line. The byline's natural width was wider than a phone, so the name and time dropped below the avatar, leaving it alone on a line. Now the byline has a 12rem basis (--byline-min), so the avatar and name stay together and only the verdict and the menu wrap below them.

No zoom in Markdown fields. textarea.field, the Markdown box behind new issues, pulls and comments, set its font back to --text-sm (13px). iOS zooms in on any field under 16px. The pull's review-state select did the same. Both now use a new token, --text-field-sm: 13px on a desktop as before, and 16px on a phone as --text-field is. No field in app.css now types in text under --text-field's size on a phone.

How it was checked

just look pull --phone --dark on the review comment, and on the comment box signed in. The new-issue page isn't recorded, but it uses the same MarkdownField. Desktop sizes are unchanged. On a phone, the approvals select on branch protection is now the same size as the "from main" select beside it.

Shots-moved: settings-branches

🤖 Generated with Claude Code

Approved

This adds a --byline-min flex-basis so a review's byline stays beside the avatar. It also adds a --text-field-sm token for textarea.field and the review-state select. The token is --text-sm on desktop and --text-lg on a phone, matching how --text-field is overridden at 640px. I found nothing that must change. The :has(.verdict) scoping keeps the basis off plain comments. The token follows the existing --text-field pattern, and both 13px fields are covered. I didn't render it, so I haven't confirmed that --text-lg is 16px.

Merged as 1104143