chadtmiller.com/knotless
git that lives in your Atmosphere account
1
10
web: The run workflow dialog lists the ref typed, not one asked before
Merged Approved
This fixes the race in the Run a workflow dialog. load() now takes a sequence number, and an answer or error from any request but the latest is dropped. That covers both the success path and the error path, so a stale failure can't clear a newer list either. The change is small and I found no problems. I didn't check whether the e2e flow passes.
All checks have passed
8 passed, 2 skipped
Merged as 65bf987
What changes
The Run a workflow dialog shows the workflows of the branch or tag typed into it, even when the default branch's answer comes back last.
The dialog asks for the default branch's workflows as it opens, and again for a ref once one is typed. Each answer used to replace the list as it arrived. Now only the answer to the latest request counts; earlier ones are dropped.
Why
The e2e flow "running a workflow when asked" failed in a batch: it types
v0.1.0and presses Tab, and the dialog still said "No workflow at refs/heads/main may be asked for there." The default branch's answer, asked first, had arrived after the tag's and overwritten it. A person typing fast enough sees the same thing, and could run a workflow at the wrong ref. The tag's workflow was never listed.How it was checked
svelte-check passes. The e2e flow that found it runs on the
e2echeck. Nothing the pages draw changes.🤖 Generated with Claude Code