~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

web: Editing a description opens a box as tall as opening one

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:web/edit-taller

What changes

Editing a pull's or issue's description opens a box 14 rows tall, as opening one does, rather than 5. Composer takes a rows, passed on to MarkdownField. Editing a comment still opens at 5.

Why

A description is often long, and 5 rows showed only its first few lines while it was being edited.

How it was checked

just look pull-open --as bob.test with Edit clicked, on desktop light and phone dark. No recorded page shows the edit box, so no shots should move.

🤖 Generated with Claude Code

edit-desktop-light.png

edit-phone-dark.png

Approved

This adds an optional rows prop to Composer, passes it to MarkdownField, and sets it to 14 when editing a pull or issue description. I found no problems. MarkdownField defaults rows to 5, so an undefined rows leaves comment editing and every other Composer use unchanged. I didn't run the checks or the page.

Merged as d75dab7