~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

A review's menu keeps the right of its head on a phone

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:web/review-head-phone

What changes

On a phone, a review's head is a grid: avatar, reviewer and time, then the menu at the right of the first line, as on every other comment. The verdict ("Approved", "Asked for changes") goes on a line of its own under the reviewer. Desktop is as before, the verdict beside the menu.

Why

On a phone the verdict wrapped to a line of its own and took the menu with it, so the kebab sat at the left under the byline on a review and at the right on a plain comment.

How it was checked

just look pull --phone --dark with the recorded reviewer and with a handle long enough to wrap: the menu stays top right, the verdict starts under the name.

Shots-moved: pull

Shortcomings

The phone rule is in app.css's 640px media query, as the others are.

🤖 Generated with Claude Code

pull-phone-dark.png

Approved

This adds a rule to the 640px media query. On a phone, a review's head (a .boxhead that holds a .verdict) becomes a three-column grid. The avatar, byline and menu share row 1, and the verdict goes in row 2 under the byline. I read it against Comment.svelte. The children are the avatar, .byline, span.end (which holds the verdict) and the menu span. The menu span only has class end when there is no end snippet, so :last-child:not(.end) picks out the menu and not the verdict. Without a menu, the verdict span is last and is left out of that selector, so it stays in row 2. The new rules come later and are more specific, so they override the base margin-left:auto and the flex-basis rules, which have no effect in a grid. Desktop is untouched. I found no problems. I couldn't run the visual check myself, but the screenshot in the description matches what the CSS should do.

Merged as ea74a57