chadtmiller.com/knotless
git that lives in your Atmosphere account
The tests run against the spaces alpha, and the stock PDS only where it differs
MergedThis makes harness/cov.mjs run only the binaries named in COV_STOCK against the stock PDS, and every binary against the alpha. The workflow sets COV_STOCK=gateway,pages,cli,spaces,oauth, and AGENTS.md and the merge-queue doc are updated to match.
The filter looks right. r.name.split(' ')[0] matches how COV_ONLY already reads names, such as gateway (test). Stored passes for stock runs are still reused, since stored is checked before wanted. The "not run" message now says why. With COV_STOCK unset, behaviour is unchanged, so a local just cov still runs everything.
I didn't run it. The claim that the gate holds at 100% with these five binaries rests on your probe, not on anything I checked. The one visible cost is that the other binaries lose stock-PDS coverage, and you state that in the description.
One nit: the new line in docs/design/merge-queue.md is much longer than the lines around it. Rewrap it.
8 passed, 2 skipped
What changes
The
testcheck runs every test binary against the spaces alpha, and against the stock reference PDS onlygateway,pages,cli,spacesandoauth: 38 runs, not 66.COV_STOCKin harness/cov.mjs names them. AGENTS.md and docs/design/merge-queue.md say so.Why
The alpha is the stock PDS with spaces added, so against both, every binary covered the same lines twice, except knotless's handling of a PDS without spaces (
space::unsupported, an org invitation kept in public records,own_spacesrefused, serve'sfollowwith no spaces index), which the alpha never answers as. A probe against the alpha alone missed 16 lines, all of those; with these five binaries against the stock PDS too, the gate holds at 100%.Measured on the runner, from scratch, no stored runs:
The run is CPU-bound in its 4 cores, so fewer runs is time saved outright: about 100s a run, a pull's and a batch's.
A change that adds code only a PDS without spaces reaches, in a binary not on the list, fails the gate with its lines named: add the binary.
Shortcomings
forge,run,mcp,weband the rest no longer run against a stock PDS. The alpha differs from it only by spaces, so what they reach on it they reach on the stock one; once spaces land in the reference PDS the stock net can go altogether.The answers check sees fewer XRPC answers (713, not ~1065): the same methods, answered once rather than once per net.
Changeset: none
🤖 Generated with Claude Code