~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

AGENTS.md says how to keep a pull from being ejected again

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:agents/queue-habits

What changes

AGENTS.md's part on landing now tells agents to merge main in just before queueing, and to read an ejected pull's log before queueing it again. They queue the same head again only when the failure is plainly not the pull's, and then fix or quarantine what failed. A pull that conflicts with one ahead of it now waits for that one, as The merge queue ejects failed pre-flights sooner and holds conflicts makes the runner do, then merges main. A new paragraph names the docs pages most conflicts are in and asks agents working at once to keep to different parts.

Why

From the queue's history (10-22 to 11-02), 30% of pulls were ejected when one or two were queued, and 54% when six or more were. Of 125 repeat ejections of one pull, 23 were at the same head as the one before: queued again with nothing changed. Of pulls queued again after a conflict, 58% were ejected again. Conflicts named docs/design/serve.md 15 times and docs/reference/api.md 12 times, more than any other file.

Shortcomings

This is guidance only. It describes the runner as The merge queue ejects failed pre-flights sooner and holds conflicts leaves it, so the two should land together.

Approved

This is a docs-only change to AGENTS.md's "Landing a change". It tells agents to merge main just before queueing and to read the failed check's log before queueing an ejected pull again. It limits requeueing the same head to failures that are plainly not the pull's. It says a pull that conflicts with one ahead of it waits for that one, then merges main. A new paragraph names the docs pages that conflict most and asks agents working at once to keep to different parts.

It also fixes the stale "can take that pull's branch merged in" advice that my review of the runner pull (3mzctwu6z4szp) flagged.

The new text matches that pull's described behaviour: the conflict wait, and an ejection that then says to merge main in. Nothing else needs to change with it. As the body says, the two should land together, and both are queued.

One small thing, not blocking: the earlier sentence in the same section still says a conflicting pull "is ejected" and to "fix it and queue it again". That's now only partly true, since a conflict with a pull ahead waits. It's worth tightening when the two land.

Merged as cfb6164