chadtmiller.com/knotless

Switch repository

Loading…

What changes

A facts line. Under a pull's or an issue's title, a line holds what is set on it, as the repository header holds what is true of the repository. A pull's reviewers show as a stack of faces, each marked approved, asked for changes, or waiting, then "3 reviewers" and a tally. It opens to one row per reviewer, linked to their review. An approval from someone outside the collaborators says it is not counted. Labels follow, and open to the label picker for those who may label. Only what has something shows. The rest is set from one Add menu.

Asking for reviews once open. The author can ask the owner and collaborators to review an open pull, from Add or from the reviewers menu, and stop asking someone not yet heard from. dev.knotless.editItem takes addReviewers and removeReviewers ([{did}], a pull's alone), going through the same forge::edit the command line uses.

The header. Edit moves into a ⋯ menu beside Subscribe (Edit title, Edit description). On a phone the title takes the full width, the state pill, Subscribe and ⋯ share the row under it as icons, and the facts stack one to a line.

Why

Labels and reviewers could only be set on the new pull page, and reviewers never after it opened. A right sidebar, as other forges do, takes width the conversation needs. On a phone the title was squeezed by the buttons beside it.

How it was checked

The gateway test asks for, stops asking and asks again for a reviewer through editItem, and an issue's ask is refused. The e2e flows stop asking and ask again from the page, and label through Add, in public and private repositories. svelte-check, layers, contrast, lexicons and fmt pass here. Menus open are in the pictures attached, desktop light and phone dark.

Shots-moved: pull, pull-open, pull-queued, pull-ejected, issue, issue-subscribe, issue-closed, issue-fixed

Shortcomings

Maintainers cannot ask for reviews: the pull record is the author's. A maintainer's review request record is the next pull, then assignees.

🤖 Generated with Claude Code

This adds a facts line under a pull's or issue's title. It shows reviewers as faces with their verdicts, and labels, and it has an Add menu. editItem gains addReviewers and removeReviewers, which go through forge::edit. The header's Edit moves into a ⋯ menu.

I found nothing that must change. The gateway, lexicon, docs (collaboration.md, api.md) and e2e/private flows are updated together. The client-facing gate doesn't apply, since no crates/knotless/src change is involved. The ask and remove paths are limited to the author on an open pull, and the issue refusal is tested.

When I read it, check had passed, but test, web, shots, lexicons, docs and e2e had not finished. Please make sure all seven pass before you land it.

Since my approval at 23488e0, the branch has one new commit (the opening test now takes a pull that asks no one as its view leaves it, with no list) and a merge of main. Neither changes what I reviewed, and I found nothing new to ask for. The pull is already in the merge queue, and its checks (check, test, web, shots, lexicons, docs, e2e) were still queued or running when I read them. Those queue checks decide the merge, so please check that all seven pass before it lands.