chadtmiller.com/knotless
git that lives in your Atmosphere account
1
10
Compaction's base test leaves its young pack room to stay young
Merged Approved
This changes the grace in compaction_keeps_the_bases_young_packs_name from 2s to 8s and the sleep from 3s to 9s. The ordering still holds. The first two packs are more than 9s old when the sleep ends, which is past the 8s grace. The last push then has 8s of room before compaction, up from 2s. That should remove the flake. The cost is 6 extra seconds in the test, which the description already says. I didn't run it. The PR leaves that to CI.
All checks have passed
8 passed, 2 skipped
Merged as c196ffe
What changes
compaction_keeps_the_bases_young_packs_namesets an 8 second compaction grace and sleeps 9 seconds, instead of 2 and 3.Why
The test needs its last push's pack to stay inside the grace while it deletes a branch and compacts. With 2 seconds, a busy runner sometimes took longer than that, so the last pack aged too and compaction folded 3 packs where the test expects 2. That is what ejected An organization's admins change its repositories' settings from the command line from the queue (
left: 3, right: 2at library.rs:976). The wider grace costs the test 6 more seconds.How it was checked
Left to CI: the test passes here only if the timing holds, which is the point.
Changeset: none
🤖 Generated with Claude Code