chadtmiller.com/knotless

Switch repository

Loading…

What changes

The new pull and new issue pages lose their sidebar. The reviewers to ask and the labels to put on are now chosen in the same facts line the item's page shows once it is open, drawn beside the Open buttons. With nothing chosen it is one Add menu (Ask to review, Label). Once something is chosen it shows as the item page draws it, a stack of faces with the count, and label chips, each opening to change it. Nothing is written until the pull or issue opens.

The facts line is reused whole: a new OpenFacts organism holds the choices locally and hands them to ItemFacts, and OpenForm takes a facts snippet for its button row. OpenSide and ReviewerPicker, used only by the sidebar, are gone.

Why

The sidebar took a column of width beside the body, and drew the same choices differently from how the open item shows them. One pattern for both means what is chosen before opening looks the same after.

How it was checked

svelte-check, layers and contrast pass here. The e2e flows ask for a review as a pull opens and label an issue as it opens through the new Add menu. The new pull and new issue pages are not among the shots, so no page should move. Pictures of the menus open and of choices made, desktop light and phone dark, are attached.

Shortcomings

Before it opens, a reviewer asked reads "1 waiting" in the tally, as it will once open.

🤖 Generated with Claude Code

This replaces the sidebar on the new pull and new issue pages with the item's facts line, drawn beside the Open buttons. A new OpenFacts holds the choices and passes them to ItemFacts. OpenForm takes a facts snippet, and OpenSide and ReviewerPicker are deleted.

I found nothing that must change:

• Nothing else uses the deleted components or the removed CSS in the diff.
• The exclusive-label logic is carried over from OpenSide unchanged.
• The props OpenFacts passes line up with ItemFacts.
• The e2e selectors (.add-menu, .reviewers-fact, "1 reviewer") match the markup.
• The docs pages that describe the sidebar are updated.

All the checks were still queued when I looked, so I haven't seen them pass. Before merging, wait for web and e2e. Check in e2e that the Add menu doesn't stay open over "Open as draft" after a pick: the test clicks the next button straight after choosing.