chadtmiller.com/knotless

Switch repository

Loading…

What changes

Clone command. On a phone, the clone command in the Code menu fades where it runs past the edge, as the tabs do.

Repository name. The slash stays with the repository name when a long name wraps, so a line never ends in a slash.

Code panel. A directory with no languages keeps the same space at the panel's top as one with languages, so the commit row no longer jumps between the root and a subdirectory.

Toolbar. On a phone, Compare & pull and Code share the line they wrap to, half each, instead of sitting stranded at its end.

Languages tip. The tip now opens below the edge, inside the panel, rather than over the tabs' underline.

Why

Fixes On a phone, the clone command is cut off at Copy with no fade

Fixes A long repository name leaves the header's / ending a line on a phone

Fixes The code panel's commit row jumps 4px between root and subdirectory

Fixes On a busy phone page, Compare & pull and Code wrap to a row of their own

Fixes The languages tip covers the tabs' underline while it shows

How it was checked

Looked with just look in desktop light and phone dark, with a long repository name, on another branch, with the hover tip, and with the Code menu open (attached).

Shortcomings

The tip now covers a little of the toolbar below the edge while it shows.

Shots-moved: directory

This pull makes five phone and layout fixes. The clone command gets the scroll-edge fade through scrollRow. The slash moves inside .repo-name. An empty lang-edge placeholder keeps the code panel's top space. Compare & pull and Code share their wrapped line. The languages tip opens below the edge.

The code looks right. scrollRow is generic: it adds the more-start and more-end classes that app.css already fades. With no [aria-current] in the <code>, it just skips the centring. I did not render the page.

One thing must change before it merges: the body has no Shots-moved: line. The repo's AGENTS.md says the shots check fails a pull that moves pages without naming them on a line of their own, as Shots-moved: <names>. This pull changes the repo header, the code panel and the toolbar on repository pages, so the check will almost certainly catch them. The shots check hasn't run yet; it's still queued. When it finishes, add a Shots-moved: line naming the pages it reports (or all). Then rerun shots, because editing the body alone moves nothing.

The other checks (check, test, web, e2e) were still queued when I looked, so I have nothing to say about them.

The pull is unchanged in what it does, plus a new commit, "Keep the repository name's switch where it was". My earlier request has not been done. The body still has no Shots-moved: line. The shots check on the previous commit failed, and the images it kept show moved pages: check, checks, commit, and probably more past the 32-output cap. The tail of its log doesn't name them all. shots on the new head is still queued.

Once shots finishes on 9846c10, add a Shots-moved: <names> line to the body, on a line of its own. Use the names the check reports, or all. Then rerun shots, because editing the body alone moves nothing. The other checks on this head are still queued or running, so I have nothing to say about them. Of the earlier head's checks, check, web, e2e and test passed.