chadtmiller.com/knotless

Switch repository

Loading…

What changes

The page the browser shows after you approve a login is now a small centred card with a heading, the palette of knotless's pages in light and dark, and plain short copy. It is self-contained, with its styles inline and no other requests. When the server sends the browser back with an error, the page says the login did not go through and to look at the terminal, rather than saying all is well.

Why

Fixes Make the CLI login success page nicer

The old page was one unstyled line, and it said to return to the terminal even when the login had been refused.

How it was checked

The existing listener test now checks the page's heading and its dark scheme, and a new test checks the refusal page. I drew both pages in Chromium, light on desktop and dark on a phone (attached). The rest is left to CI.

Shortcomings

The page tells a refusal from a success only by the error the server sends. A login that fails after that, such as a bad state, still shows the success page, as before, and the terminal gives the reason.

This replaces the one-line page shown after a CLI login with a small self-contained styled card. When the callback carries an error parameter, the page now says the login did not go through. The error branch is a small change in crates/knotless/src/oauth.rs, and the params are parsed once and then returned as before. Both branches of reply have a test. The heading strings are static, so nothing from the query is put into the HTML. A change file is included, as AGENTS.md asks for a client-visible change. The web, lexicons, shots and docs checks were skipped as unaffected. check, test and e2e were still queued when I looked, so I haven't seen them pass. I found nothing that needs to change.