chadtmiller.com/knotless

Switch repository

Loading…

What changes

The install script brings the runner, labeller and reviewer. Each release's tarballs now hold knotless-run, knotless-triage, knotless-agent and the reviewer's knotless-claude-review script, beside knotless, git-remote-knotless and knotless-mcp, for all four targets. install.sh puts all seven in place. Running a runner, labeller or reviewer on your own machine no longer needs a clone of knotless and Rust to build it.

Older releases still install. A release from before these shipped holds only the first three, and install.sh installs those and passes over the rest. The first three are still required in every release.

The guides say so. Getting started lists what the install brings. The workflows guide's "Start a runner" says the runner comes with the install and needs Docker. The reviews guide installs with the script rather than cargo install from a checkout. The README, the CLI reference and deploy/README.md list the seven.

Why

The three crates build for every target the client does, since none uses anything Linux-only. But they were built only into the server image, so anyone running their own needed a clone, Rust and a cargo install, or the whole image. This was the first gap in Self-hosted runners: ship knotless-run and document running your own.

How it was checked

installing_a_release now builds its 0.2.0 archive with all seven binaries and checks that each installs and runs. Its 0.1.0 archive holds only the first three, and the test checks that it installs without knotless-run. deploy/build-client.sh was not run here. The release workflow runs it at the next version, which is when the four new targets first build knotless-run, knotless-triage and knotless-agent.

Shortcomings

knotless-claude-review is a Node script, so a reviewer still needs Node and Claude Code, as the guide says. Nothing here adds a standalone service file for a runner. The other parts of the runner issue (reloading watched repositories, watching private ones) are not addressed.

🤖 Generated with Claude Code

This pull adds knotless-run, knotless-triage, knotless-agent and knotless-claude-review to the release tarballs (deploy/build-client.sh) and to install.sh. Older releases still install the first three. I found nothing that must change, but I did not build anything.

• install.sh: the first three binaries are still required, so a broken release still fails. The other four are skipped when the tarball doesn't hold them.
• build-client.sh: crates/knotless-agent/claude-review exists and is executable. It is installed under the name knotless-claude-review, which matches install.sh.
• Test: installing_a_release covers both the new 0.2.0 layout and the old 0.1.0 one.
• Docs: the guides, README, CLI reference and deploy/README.md are updated, and the change file is minor.
• Checks: check and test were still running and docs and e2e were queued when I looked, so I can't say whether they pass.
• Risk: as the pull body says, build-client.sh wasn't run. The first cross-build of knotless-run, knotless-triage and knotless-agent for the other targets happens in the release workflow, so watch that run.