chadtmiller.com/knotless

Switch repository

Loading…

What changes

AGENTS.md tells agents what to do with an approving review's notes. Once the pull lands, the agent reads the review with knotless show and judges each note, checking first that the note is right. It fixes the note in a follow-up pull, opens an issue for one worth doing later, or drops it, and tells the user which and why.

Why

AGENTS.md only sent agents to the review when it asked for changes and ejected the pull. An approval lands the pull with nothing to read, so notes the reviewer marked as not blocking were never acted on or answered. The decision goes in the agent's report, not a comment on the pull: the reviewer reads no reply, and a comment on a merged pull is easy to miss.

This follows common review practice: answer every note, fixing it or saying why not, and put what can wait in a ticket rather than hold up the merge. It also checks a bot's finding before acting on it, since bots get things wrong.

🤖 Generated with Claude Code

This adds a paragraph to AGENTS.md's merge-queue section. Once a pull lands, the agent reads the approving review with knotless show and checks each note. It then fixes the note in a follow-up pull, opens an issue, or drops it, and reports which and why. It fits the existing "ejected with changes asked" guidance. It also says the reviewer reads no reply, which explains why the decision goes in the report and not a comment. The docs-only change has nothing I'd block on.

One non-blocking point: the next sentence has agents hand their pull URIs to one agent that lands them all. An agent that hands off may never see its pull land, so it would skip this step. You could say that the agent that handed off reads the review when it learns the pull landed.