~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

The reviewer reviews group-host's pulls, a private repository named

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:deploy/review-group-host

What changes

knotless.dev's reviewer, review.knotless.dev, watches chadtmiller.com/group-host as well as every public repository chadtmiller.com and grain.social hold. --owner lists only public repositories, so a private one is named in KNOTLESS_REVIEW_REPOS.

Why

group-host's pulls ask review.knotless.dev for a review, and it is shared with that account, but no review came: the agent never read the repository. Its DID is already in KNOTLESS_BOT_DIDS, for the OAuth session a private repository is read with.

How it was checked

A workflow value only; the deploy that follows is the check.

Changeset: none

Approved

This adds chadtmiller.com/group-host to KNOTLESS_REVIEW_REPOS in the deploy workflow, because --owner only lists public repositories. I checked how the value is used. deploy/deploy.sh writes it to the env file, and deploy/docker-compose.yml puts it on the reviewer's command line right after ${KNOTLESS_REVIEW_ARGS}. A positional handle/name after the --owner flags should therefore be read as a repository to watch. The comment update matches the change. As the body says, the deploy is the real check. I didn't verify that the agent accepts mixed --owner and positional repositories.

Merged as aa4ff59