~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

searching_code is quarantined while code search's paging is made stable

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:harness/quarantine-searching-code

What changes

searching_code is quarantined on both nets until 2026-11-10.

Why

Its second page of needle_&limit=1 can repeat the first page's repository, as Zoekt orders files of equal score as its shards finish, and the cursor is an offset into that order. It failed one pull's pre-flight twice in a row at a head that does not touch code search. Code search's next page can repeat the last one's file has the cause and the fix it needs; the quarantine goes with that fix.

How it was checked

The file parses. CI runs the rest.

Shortcomings

While quarantined, a real break in code search's paging fails only when searching_code fails again run alone, three times.

🤖 Generated with Claude Code

Approved

This adds searching_code to harness/quarantine.json for both nets (spaces and stock), with an expiry of 2026-11-10. That is six days out, so the quarantine can't be left in place indefinitely.

  • Test location: The test is fn searching_code in crates/knotless-serve/tests/web.rs, so the web (test) binary name matches the existing gateway (test) entries.
  • Quarantine mechanism: harness/cov.mjs matches q.net, q.binary and q.test exactly, and drops entries once until has passed. The entries are valid JSON and follow the existing format.
  • Not verified: I couldn't find where cov.mjs builds the (test) suffix, so I haven't confirmed the binary string. A wrong name would only leave the test unquarantined. The checks would then fail visibly rather than hide a failure.
  • Body: It states the shortcoming honestly: a real paging break will only show if searching_code fails three times when run alone. That is the intended trade-off while the fix is pending.
Merged as e66e714