chadtmiller.com/knotless
git that lives in your Atmosphere account
1
10
A pull held for a review no longer tells its author to approve it
Merged Approved
This changes the wording of the "lacks a review" message in the CLI (approvals::HOW and FORCE) and the MCP tools (APPROVE_HERE). It now says anyone but the author who may write can approve, and that the owner merges past it with --force, whether or not it's their own pull. I searched for other users of the old text. knotless-mcp and knotless-run's queue find and replace on approvals::HOW, so they pick up the new wording. The four tests that assert the old wording are updated, and the changeset is included. The only other place the old wording appeared was prose in docs and comments, which isn't affected. I didn't run the tests or check CI.
All checks have passed
9 passed, 1 skipped
Merged as ed19589
What changes
When a pull lacks the review its branch asks for,
knotless mergeand the merge queue said "Those who may write approve it withknotless comment … --approve". The author may write, but cannot approve their own pull, so the command it gave them could only fail. It now says anyone but its author who may write approves it, and that the owner, its author or not, merges past it with--force. The MCP tools' text says the same.Why
An owner ran the command the queue gave for their own two pulls and got "is your own pull: comment on it rather than review it". What the tools tell agents and people to run should work.
🤖 Generated with Claude Code