chadtmiller.com/knotless

Switch repository

Loading…

What changes

AGENTS.md's "Landing a change" covers a pull the queue turns away with not reviewed as main asks because review.knotless.dev approved an earlier head and has stopped reviewing, having spent its --rounds. When nothing since that head is more than main merged in or the review's own notes answered, the agent dismisses the review with a reason (knotless dismiss) and queues the pull again. Where the review asked for changes and is wrong, the agent says why and asks the owner whether to dismiss it. It never uses --force to get past a gate.

Why

AGENTS.md said a wrong review is overcome by the owner's approval of the head. Agents here write as the owner, and the owner's approval never counts on their own pull, so that route could not work. It also said nothing about a gate that has stopped reviewing. knotless-agent keep updates turned-away pulls and queues them again hit both, and landed with --force, so its last head, a merge of main, was never checked before it merged. A dismissal stands in for a gate's review, the owner's own pull included, as docs/design/collaboration.md's Gates section says, and the queue's pre-flights still run.

How it was checked

Read against docs/design/collaboration.md (Gates, Dismissing a review). It changes only AGENTS.md, so check and test are all that run.

🤖 Generated with Claude Code

This changes only the AGENTS.md "Landing a change" paragraph. When review.knotless.dev approved an earlier head and then stopped reviewing, the agent now dismisses the review with a reason and queues the pull again, as long as nothing since is more than a main merge or answers to the review's own notes. Where the review asked for changes and is wrong, the agent asks the owner whether to dismiss it. It never uses --force. I checked this against docs/design/collaboration.md. The dismiss syntax (knotless dismiss <url> <pull> <reviewer> <reason>) matches lines 90–102. A dismissal stands in for a gate's review, including on a maintainer's own pull (lines 102 and 725–726). The text is clear and I have no changes to ask for.