chadtmiller.com/knotless

Switch repository

Loading…

What changes

deploy, release and publish-lexicons name main's seven checks in after instead of waiting for them in a step. Each is held back, holding no job, until the checks pass at its commit, and is filed failed without running if one fails. The waiting steps are gone: deploy's checks done and checks pass, and the wait-for-checks step in the other two, so its pin leaves .knotless/uses.lock. deploy/README.md says how a deploy now runs.

Why

The runner that checks main runs two jobs at once. On the push that landed pages, deploy and publish-lexicons started first and took both, each waiting in a step for test, web and shots, which then could not get a job until those waits ran out, 25 minutes on, failing the deploy. With after, waiting costs no job.

The cost is that deploy builds its image after the checks rather than while they run: a push goes live a couple of minutes later than it did when nothing was stuck.

🤖 Generated with Claude Code

This moves deploy, release and publish-lexicons from waiting for main's seven checks in a step to naming them in after. I found nothing that must change.

• Semantics. after is documented in docs/reference/workflows.md and in the runner (crates/knotless-run/src/lib.rs). A run waits for the named checks at its own commit and holds no job. It is filed failed without running if one fails or is cancelled. A named workflow with no check at that ref is skipped, and the log says so. That is why release and publish-lexicons still work when asked on a non-main branch, and why the new publish-lexicons comment ("waits for those of them that ran there") is right.
• Deploy. The removed checks done and checks pass steps were the only places that dropped the candidate on a failed check. Now a failed check means the run never starts, so no candidate is built and there is nothing to remove. The ~/.moved and unless-moved supersede logic around build and up is left intact. The README and the header comment match the new flow.
• Lockfile. Removing the wait-for-checks@2 pin from .knotless/uses.lock is consistent, because no workflow uses it any more.
• Checks. At review time the pull's own checks were still queued or running (check was running, and test, web and docs were queued). I judged the pull from the diff alone.

A small leftover, which doesn't block this: AGENTS.md says "deploy.yml still runs, and waits for them as ever". That is still true, but "waits" now means after.