chadtmiller.com/knotless
git that lives in your Atmosphere account
1
10
The sites test takes a site down by its repository, its record and its owner
Merged Approved
This extends the sites test so it takes the live site down by its repository, its dev.knotless.site record and its owner's DID. It uses Index::take_down for each, expects 404, then restores and expects 200. The owner's own --down still runs last.
I checked the subjects against the code and they match the lookup:
Sites::mapinsites.rschecksat://{did}/dev.knotless.repo/{name}againstdown. The test'srepoURI usessite, which is the repo name froms.url("site").Index::sitefilters on the site URI,at://{did}/dev.knotless.site/{key}, and ondid. The test'srecordanddidsubjects cover both.take_downwithapplied=falsedeletes the takedown row, and thetakedown_uptrigger clearsdownonly when no other row keeps the subject down. Each restore therefore returns the site to 200 before the next subject.take_downcallsstamps.mark_all(), so the cached map is invalidated and thewait_untilpolls will see the change.
I did not run the test and read no check results. It touches only the test file, so Changeset: none is right. I have no concerns.
All checks have passed
9 passed, 1 skipped
Merged as f0b4675
What changes
The sites test now takes a live site down as the operator would, by each subject that hides it: its repository, its
dev.knotless.siterecord, and its owner's account. Each time, the site answers 404, and once restored, 200 again. Before, it checked only the owner's ownknotless site --down.Why
Serve hides a site whose repository, record or owner is taken down (
sites.rs,Index::site), but no test held it, so a change to the lookup could serve a taken-down repository's site.Changeset: none
🤖 Generated with Claude Code