chadtmiller.com/knotless

Switch repository

Loading…

What changes

Clicking a picture a check made, on a check's page or a pull's checks, opens the picture at full size. Before, it opened knotless's 404 page.

Why

The picture's link goes to /xrpc/dev.knotless.getCheckImage, which knotless-serve answers. SvelteKit took the click as a page of its own and, with no route there, drew its 404. The same URL loaded in the <img> and by curl, so only the click failed, for public and private repositories alike. The link now has data-sveltekit-reload, as the Raw buttons do, so the browser asks the server.

How it was checked

Fetched a public check picture from prod with curl, which answered 200 image/png, so the server was never at fault. The pixels do not change. The shots check shoots the pages whose HTML differs, and they should not move. The rest is left to CI.

Shortcomings

A private repository's picture still needs the viewer's session, which the browser sends with the cookie.

🤖 Generated with Claude Code

This adds data-sveltekit-reload to the check picture link in RunImages.svelte, so the browser requests the server's /xrpc/dev.knotless.getCheckImage URL. SvelteKit no longer treats the click as an in-app route. It is the same attribute the Raw buttons already use. It is a one-line change with a matching comment update, and I found nothing wrong. I didn't run it or check CI.