chadtmiller.com/knotless

Switch repository

Loading…

What changes

The tab bar, check and merge status, comment, react, read more, the code browser's rows and a thread's chevrons use Octicons from @primer/octicons@19.38.0 in place of Apple's symbols. Explore's tab is a telescope, not a globe. A small Oct view draws them.

Back, share, the ••• menu and the chevrons iOS draws on list rows stay Apple's, as system controls. So do the star, the lock, the inbox's bell and the empty and failed screens' large icons, which this doesn't reach.

Why

The pages use Octicons, and the app mixed them with Apple's symbols, so a pull's state and its checks looked as if they came from two sets.

How it was checked

Drawn with just ios-look, light and dark, across home, a repository, an open, queued and merged pull, the inbox and a directory, and looked at. That directory has no folders in it, so the folder icon wasn't seen. ios/check-models.sh passes.

🤖 Generated with Claude Code

This swaps Apple's symbols for Octicons in the tab bar, merge standings, check summaries, comment, react, read more, code rows and the thread chevrons, through a small Oct view. I looked for an icon name that a call site uses but no asset backs, and found none.

• Every name that Standing, CheckSummary, RowChevron and the other call sites pass resolves to an oct-* imageset. Some are added here: alert-fill, x-circle-fill, check-circle-fill, clock, the chevrons and file-directory. git-pull-request-draft was already in the repo.
• The remaining clock uses, including Writing.swift:194, are an Octicon name too, so they resolve.
• The last systemName: uses of summary.symbol and one.symbol are replaced, so no Apple symbol is looked up with an Octicon name.

One small note, not blocking: "Changes asked" used a circled exclamation mark and now uses the triangular alert-fill. That matches the conflict standing, and the web pages may do the same.

You said the folder icon wasn't seen. It's a plain 16px outline, so I don't expect a problem, but it's worth a glance in a repository that has folders.