chadtmiller.com/knotless

Switch repository

Loading…

What changes

Review. An open pull has a green Review button, on its page beside Comment and on Files changed. It opens a sheet with a message box, then Comment, Approve and Request changes as cards, and a button that says what it will do. The pull's author can only comment: the other two are dimmed and say why, as readers take no verdict from a pull's author. The Comment button now only comments. As on the pages, a verdict can go with no message, which the app refused for Request changes before.

File headers. A diff's file headers are taller, at 52pt, with a larger path and an Octicon chevron that turns as the file folds, in a pull's files and a commit's.

Rows and toolbar. Rows that open a screen are at least 56pt, on home, a repository and a profile's organizations, and a favorite's is as much taller. Home's new issue and search icons are 24pt and take the text colour rather than the accent, which the toolbar was applying over the colour they asked for.

Floating buttons. Comment, Review and Read more share a size, a little smaller than Comment and Read more were.

Why

The app read small and cramped beside GitHub's, and a review was a segmented picker above a comment box. A review now reads as a choice, with what each one means. Color.successFill is new because success is too light in dark mode for white text on it. The "Open" pill's green is the same one, now by that name.

How it was checked

just ios-look in light and dark: home, repository, files, pull-open, and the sheet with Approve chosen and on the author's own pull. Home read live from knotless.dev with ios/run.sh. ios.yml checks the writes against their lexicons.

Shortcomings

No review was sent, as ios-look writes nothing and a debug build's tokens only read. A long path in a file header, a favorite's row, a profile's organizations and a sheet with a message written were not looked at. "Jump to file" on a commit keeps its larger text. File headers have no viewed mark, as there is nothing to keep it in.

In the simulator, sign-in once failed with iOS saying the app is not associated with knotless.dev, though the file on the site and Apple's CDN are right. This change does not touch that, and the cause was not found.

Review

A look at the pictures, then ReviewSheet in ios/Knotless/Views/Writing.swift.

🤖 Generated with Claude Code

This pull adds a ReviewSheet for reviewing a pull, with a Review button on the pull page and on Files changed. The Comment composer now only comments. It also makes file headers and rows taller and adds Color.successFill. I read the whole diff and checked what it uses: Account.signedIn and person, Color.accent, and the octicon assets check, x, chevron-down and check-circle-fill all exist. I found no bugs. The logic for the pull author, which can only comment, is sound. A verdict can go with no message, and a comment still needs text. The sheet won't dismiss by swipe once there is text. I couldn't build the app, and the pull says no review was ever sent, so the write path is unrun. It reuses Writes.comment, which ios.yml checks against the lexicons.

One small note: FilesView passes {} as sent, so after a review from Files changed nothing refreshes. That is harmless there, since the page shows no reviews.