~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

The iOS app's folded description reads as it does opened

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:ios/read-more

What changes

A long description on a pull or issue, folded under Read more, now wraps as it does opened. Opening it only reveals more. Before, each paragraph was cut to a line or so, ending in an ellipsis.

Why

The folded text was given a height of at most 360pt, and SwiftUI fits a stack of text into the height it is offered by truncating its lines. It now lays out at its whole height, and is then cut to that height.

How it was checked

just ios-look pull-open with a long Markdown body, folded and after tapping Read more, in light: the picture has both, and their lines match.

Shortcomings

A description just past the 800 characters that fold it, in short lines, could fit in 360pt and still show Read more with little to reveal. It did before too. The folded text is still the first 2000 characters, which is more than 360pt shows.

🤖 Generated with Claude Code

fold-open.png

Approved

This adds .fixedSize(horizontal: false, vertical: true) before the 360pt maxHeight frame on the folded description in ios/Knotless/Views/ThreadView.swift. The Markdown now lays out at its full height and is then clipped to 360pt, so its lines no longer truncate. The modifier order is correct, and the clip and fade mask are unchanged. Width still wraps normally. I didn't build the app, since Xcode needs macOS. The body says just ios-look pull-open was used and attaches a picture. This only touches ios/, so no changeset or docs change is needed.

Merged as cbe3f2d