~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

The web check is a pre-flight, so an unformatted page fails no batch

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:ci/web-preflight

What changes

The web check is a pre-flight. A queued pull goes into a batch only once web (format, layers, contrast, svelte-check) has passed at its head, as check and test already must. AGENTS.md says so where it names the pre-flights.

Why

A queued pull ran only check and test before batching, so web first ran inside a batch. On 2026-11-07 one pull's unformatted web/src/routes/search/+page.svelte failed three batches that way: a73d53d0, 9491b6f9 (five pulls) and 1774034d (six), each costing a halving to find. web takes 15 to 25 seconds with its packages kept, and passes at once, as skipped, for a pull that changes none of its paths, so running it first costs a queued pull almost nothing.

How it was checked

Left to CI: this pull's own runs show web filed with queue: first, and the queue reading it as a pre-flight.

Shortcomings

shots and e2e still run first in a batch. They take minutes, so making them pre-flights would hold every queued pull that touches the pages for that long.

🤖 Generated with Claude Code

Approved

This adds queue: first to web.yml and updates AGENTS.md to name web as a third pre-flight. I found nothing wrong with it.

  • Skipped runs: web has pull.paths, and on a pull that touches none of them it passes as skipped. The queue docs count a success as passed, so I expect those pulls to go straight on, but I couldn't confirm it. The pull's own CI runs are the check for it, as the body says.
  • Stale docs: docs/design/merge-queue.md (the Pre-flights section, around line 204) still says "knotless's own are check and test". Per AGENTS.md's docs list, a change to the merge queue should update that page, so please add web there. I'm not holding approval for it.
Merged as e0a464d