chadtmiller.com/knotless
git that lives in your Atmosphere account
1
10
The web check is a pre-flight, so an unformatted page fails no batch
Merged Approved
This adds queue: first to web.yml and updates AGENTS.md to name web as a third pre-flight. I found nothing wrong with it.
- Skipped runs:
webhaspull.paths, and on a pull that touches none of them it passes as skipped. The queue docs count asuccessas passed, so I expect those pulls to go straight on, but I couldn't confirm it. The pull's own CI runs are the check for it, as the body says. - Stale docs:
docs/design/merge-queue.md(the Pre-flights section, around line 204) still says "knotless's own arecheckandtest". Per AGENTS.md's docs list, a change to the merge queue should update that page, so please addwebthere. I'm not holding approval for it.
All checks have passed
8 passed, 2 skipped
Merged as e0a464d
What changes
The
webcheck is a pre-flight. A queued pull goes into a batch only onceweb(format, layers, contrast, svelte-check) has passed at its head, ascheckandtestalready must. AGENTS.md says so where it names the pre-flights.Why
A queued pull ran only
checkandtestbefore batching, sowebfirst ran inside a batch. On 2026-11-07 one pull's unformattedweb/src/routes/search/+page.sveltefailed three batches that way:a73d53d0,9491b6f9(five pulls) and1774034d(six), each costing a halving to find.webtakes 15 to 25 seconds with its packages kept, and passes at once, as skipped, for a pull that changes none of its paths, so running it first costs a queued pull almost nothing.How it was checked
Left to CI: this pull's own runs show
webfiled withqueue: first, and the queue reading it as a pre-flight.Shortcomings
shotsande2estill run first in a batch. They take minutes, so making them pre-flights would hold every queued pull that touches the pages for that long.🤖 Generated with Claude Code