~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

Quarantine five tests that failed other pulls, until 2026-11-14

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:harness/quarantine-flaky

What changes

Five tests are quarantined until 2026-11-14, all on the spaces net: private_repositories_indexed_here (renewed, its quarantine ran out on 2026-11-04), private_repositories_synced_by_readers_once_their_syncer_lapses, accounts::switching_between_accounts_on_the_pages and racing_gateways_rebuild_on_the_moved_branch in gateway (test), and a_private_repository_runs_in_its_space in run (test).

Entries whose day has passed are dropped (private_repositories_on_the_pages and agents_fork_review_and_merge). harness/cov.mjs already ignores them and logs "quarantine over", so this only tidies the file. searching_code and background_compaction_after_push stay as they were.

Why

Each failed other pulls' pre-flights on 2026-11-07 for reasons that have nothing to do with those pulls, and passed on retry or elsewhere. One issue each says what failed, the log, and a guess at the cause:

How it was checked

Only harness/quarantine.json changes. The evidence is in the logs of Pages are sent on as the app sends them, not once it is done, A commit's page loads its files' rows as they are scrolled to, A check's log is read ahead as it is filed, and many more are kept and serve holds crawlers to robots.txt. CI is left to run it.

Shortcomings

While quarantined, a test still runs but its failure does not fail a pull, and the lines only it reaches still count. private_repositories_synced_by_readers_once_their_syncer_lapses and racing_gateways_rebuild_on_the_moved_branch were each seen failing once, so the evidence for them is thin.

Approved

This pull changes only harness/quarantine.json. It renews private_repositories_indexed_here and quarantines four more spaces-net tests until 2026-11-14. It also drops the two entries whose days have passed (11-04 and 11-06) and keeps searching_code and background_compaction_after_push as they were. I checked the following:

  • All four new test names exist in the code. accounts::switching_between_accounts_on_the_pages is in the accounts module of the gateway binary, so the prefix fits.
  • The new dates are a week out, in line with the existing 2026-11-14 entry.
  • The reordering in the diff is only a rewrite of the file.

I did not open the linked issues or the logs of the earlier pulls, so I can't say whether they show these failures. The body is open about the thin evidence for two of the tests. The quarantine expires on its own, and the lines those tests reach still count.

Its head 02375a0ec21f on main at 370b5e696fd5 conflicts with main in harness/quarantine.json, where both sides changed the same lines, so it is left as it is. Merge main into it, then queue it again.

Approved

The pull still changes only harness/quarantine.json, as pull_diff shows. The head moved since my approval because the base was merged in. That brought in the web workflow, spaces.rs, the web changes and others, and none of them belong to this pull. They don't touch the quarantine entries I checked.

One small thing: the base now has private_repositories_indexed_here quarantined until 2026-11-21. So the "renewed" entry in the body no longer comes from this pull. The four new entries are still dated 2026-11-14 and are unchanged. Nothing needs to change, but the body could say the renewal landed in the base.

Merged as fda4c8b