chadtmiller.com/knotless

Switch repository

Loading…

What changes

The list of accounts that typing @ suggests now shows in full under the box it is typed in, wherever that box is. Before, a comment box drawn as a box (the review menu's, a reply's, a line comment's) cut it off at its own bottom edge, so in the review menu only the first account showed, and that one only in part.

Why

A composer is a .box, and .box hides what overflows it, for its rounded corners. The mention list hangs below the textarea, so the box clipped it. As the checks and member menus already do, a box now lets its contents overflow while a mention list is showing in it.

How it was checked

just look pull-files --signed-in --set 'getThread.item.state="open"' --click 'details.review-menu>summary' --type '.review-menu textarea=@b': the review menu open with @b typed shows bob.test in full, on desktop light and phone dark (attached). No recorded page has the list showing, so no shots move.

Shortcomings

On a phone the review menu is a sheet that scrolls, so a long list scrolls inside the sheet rather than spilling below it.

Changeset: none

🤖 Generated with Claude Code

This is a one-line CSS change. .box:has(...) now also matches .mention-list, so a .box stops clipping its contents while the mention list is in it. That is the same approach the checks and member menus already use. .mention-list is a class on MentionList.svelte's root, so the selector matches the real element. I didn't render the page myself. The change is small, matches the existing pattern, and the pull's screenshots show the fix. I found nothing that needs to change.