~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

knotless-run: The gate test waits 8 seconds for a review, not 30

Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:run-tests-faster
crates/knotless-run/tests/run.rs+5−3
@@ -4080,8 +4080,10 @@ fn a_merge_queue_waits_for_its_gate() {
let rt = tokio::runtime::Runtime::new().unwrap();
let q = Line::new(&rt);
let url = q.url.clone();
// Room for a loaded run's pass to see it waiting before the wait is up.
let wait = Duration::from_secs(30);
// Room for a loaded run's pass to see it waiting before the wait is up
// (the check below is skipped when it does not), and no more: the test
// sits out what is left of it.
let wait = Duration::from_secs(8);
let l = q.lander(&rt, "state.json", |opts| opts.review_wait = wait);
let mut gate = Sandbox::new();
gate.set("KNOTLESS_APPVIEW", &q.base);
@@ -4136,7 +4138,7 @@ fn a_merge_queue_waits_for_its_gate() {
let shown = q.shows(&b, "merge queue: ejected");
// What it waits for and how long, then how to give it.
let wanted = format!(
"a review of its head from @{handle}. It waited 30s for that review. Anyone but its author who may write"
"a review of its head from @{handle}. It waited 8s for that review. Anyone but its author who may write"
);
assert!(shown.contains(&wanted), "{shown}");
}