~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

The iOS app is version 1.0, for iPhone

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:ios/version-1

What changes

The iOS app is version 1.0, build 7, the one sent to App Review for the App Store. It is an iPhone app only: an iPad runs it in a phone's window, as it does any iPhone app.

Why

App Store Connect's first version is 1.0, and the build it takes has to carry that version, where every build so far said 0.1.0. The iPad has never had a layout of its own, and keeping it would have App Review judge one and ask for iPad screenshots: it can come back once it is laid out for.

How it was checked

Build 7 is archived and uploaded from this commit.

Changeset: none

🤖 Generated with Claude Code

Approved

This sets the iOS app to marketing version 1.0, build 7, and limits it to iPhone (TARGETED_DEVICE_FAMILY: "1"). It also removes the iPad-only orientations key, which no longer applies. I found no other place in the repo that sets the old version or device family. The MARKETING_VERSION and TARGETED_DEVICE_FAMILY matches are only the lines being changed, and I didn't search for a checked-in Xcode project. I didn't check whether the iPad key is used elsewhere, such as in a separate Info.plist. The change is small and matches its description.

Approved

Since my approval, the only change is in ios/project.yml. TARGETED_DEVICE_FAMILY: "1" moves from the project-wide settings to the app target and the UI-test target. That matches the new comment: XcodeGen's per-target preset of "1,2" would otherwise override the project-level value, so the app would still have targeted iPad. The version (1.0) and build (7) are unchanged. This still does what the description says. I didn't build the project.

Merged as e70f769