chadtmiller.com/knotless
git that lives in your Atmosphere account
1
10
A released change file stays out, and rerun keeps its doc comment
Merged Approved
The diff does what the body says. It deletes the already-released change file .changeset/owner-watches-private.md, and a search of the base finds no other reference to it. In Writes.swift it moves the rerun doc comment back onto rerun, so deleteComment keeps only its own. It changes no code. I didn't check CHANGELOG.md for the 0.12.0 entry.
All checks have passed
8 passed, 2 skipped
Merged as b211fbd
What changes
.changeset/owner-watches-private.mdcomes out again. 0.12.0 already shipped it (e0447f50 took it out and added its entry toCHANGELOG.md), but iOS app edits and deletes one's own comments and opens authors' profiles was cut from a branch that still had it and put it back, so the nextknope releasewould raise the minor version for it and list it a second time.rerunkeeps its own doc comment. Inios/Knotless/API/Writes.swiftthe same pull putdeleteCommentbetweenrerun's doc comment andrerun, sodeleteCommentcarried both andrerunnone, as review.knotless.dev noted there.Why
Both came in with that pull, found by its review after it had landed.
How it was checked
git show 3357f98b --statlists the change file, andCHANGELOG.mdalready has its entry under 0.12.0. The Swift change moves one comment line and no code.Changeset: none