~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

A released change file stays out, and rerun keeps its doc comment

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:ios/comment-actions-followup

What changes

.changeset/owner-watches-private.md comes out again. 0.12.0 already shipped it (e0447f50 took it out and added its entry to CHANGELOG.md), but iOS app edits and deletes one's own comments and opens authors' profiles was cut from a branch that still had it and put it back, so the next knope release would raise the minor version for it and list it a second time.

rerun keeps its own doc comment. In ios/Knotless/API/Writes.swift the same pull put deleteComment between rerun's doc comment and rerun, so deleteComment carried both and rerun none, as review.knotless.dev noted there.

Why

Both came in with that pull, found by its review after it had landed.

How it was checked

git show 3357f98b --stat lists the change file, and CHANGELOG.md already has its entry under 0.12.0. The Swift change moves one comment line and no code.

Changeset: none

Approved

The diff does what the body says. It deletes the already-released change file .changeset/owner-watches-private.md, and a search of the base finds no other reference to it. In Writes.swift it moves the rerun doc comment back onto rerun, so deleteComment keeps only its own. It changes no code. I didn't check CHANGELOG.md for the 0.12.0 entry.

Merged as b211fbd