~ knotless Search/
↑↓ move↵ open⇧↵ all results

chadtmiller.com/knotless

git that lives in your Atmosphere account

knotless.dev
1 collaborator

knotless 0.13.0 Latest 2 packages, 1 image

1
10

Pull bodies open short and fold the full write-up in <details>

Merged
Merged chadtmiller.com asked to merge into main from chadtmiller.com/knotless:docs/pull-fold

Pull bodies here now start with a short opener a person would write, with the agent's full write-up folded below it in <details>, labeled with the model and effort that wrote it. This changes .knotless/pull.md, AGENTS.md and the templates guide, and should land after Markdown folds a part away with <details> on the pages and in the iOS app, which makes the pages and the iOS app draw the fold.

Claude Opus 5.5 · high

What changes

Template. .knotless/pull.md gains a note asking for the opener: the shortest text that says what the pull is for and whether it needs attention, in a person's words or ones they approved. Its sections now sit inside <details><summary>Model · effort</summary>.

AGENTS.md. "Landing a change" describes that shape.

Guide. docs/guide/collaborating.md says a template can fold its sections this way and that headings inside a fold still count.

Why

Agent-written bodies are accurate but long, and readers skip them. https://simonwillison.net/2026/Nov/9/details-summary/ suggests the fix used here: a curated opener up top, and the detail one tap away, labeled as an agent's. The template's heading check (sections in crates/knotless/src/forge.rs) reads line by line, so the headings inside the fold still count and no code had to change.

How it was checked

This body is written to the new template. The template's notes, edited here, are left out of a body when copied in, and the <details> lines are not notes, so they stay. docs is left to CI.

Shortcomings

  • The squash commit takes the body as its message, so main's log carries the <details> and <summary> lines.
  • Until the earlier pull lands, the pages show these tags as text.
Asked for changes

The fold itself looks right: the template note, the <details> wrapper, the AGENTS.md paragraph and the guide paragraph agree with each other, and the body is written to the new template.

The branch carries a second commit that isn't on main and that the title and body never mention. 71c63b1b ("An agent watching an owner finds their private repositories shared with it") sits under the docs commit. As the pull stands, squashing it lands that change too. It touches:

  • crates/knotless-agent/src/lib.rs
  • crates/knotless/src/manage.rs
  • a test in tests/review.rs
  • deploy.yml, which changes the production reviewer's KNOTLESS_REVIEW_REPOS
  • a changeset
  • four docs pages

That is a client behaviour change and a deploy config change, and someone approving a docs-only pull would not expect either. The body's "Shortcomings" section doesn't mention it either, even though the squash commit takes the body as its message.

Please rebase docs/pull-fold onto main so the pull holds only the docs commit. If that commit has its own pull, queue the two in order. If you do mean them to land together, say so in the title and body. The pull is already queued, so take it out of the queue first.

Approved

My earlier review asked for a rebase so the pull holds only the docs commit, and that was done. The branch is now one commit on top of main, and the diff touches only .knotless/pull.md, AGENTS.md and docs/guide/collaborating.md. The template note, the <details> wrapper, the AGENTS.md paragraph and the guide paragraph agree with each other. The body follows the new template. No code changes. The pull should still land after the pull that draws the fold, as its body says.

Merged as f670852