chadtmiller.com/knotless
git that lives in your Atmosphere account
1
10
private_repositories_indexed_here looks for its private repository alone
Merged Approved
The test now looks for the private repository by owner DID, name kept and private == true in the parsed listRepos answer. It no longer matches any "kept" in the body, so public kept repositories from other test binaries can't satisfy it. I checked appview.rs: private: true is set only on repositories the viewer can read through a space, and each repo serializes its did. did and Value are already in scope in the test. The diagnostic loop is back to wait_until(|| !finds()), and the quarantine entry is gone. The change matches the cause in the body. I didn't run the test, and the body says CI is the check.
All checks have passed
8 passed, 2 skipped
Merged as 2ade570
private_repositories_indexed_herefailed now and then on the runner, never locally, and was quarantined until Nov 21. The cause: it searchedq=keptand took any"kept"in the answer for its private repository, but other test binaries make public repositories calledkepton the same test PDS, which this server's index follows. Now it looks for the private one by owner, name andprivate, and comes out of quarantine. A quick look will do.Claude Opus 5.5 · high
What changes
The test's
findsparseslistReposand looks for a repository of the owner's DID, namedkept, markedprivate, rather than the text"kept"anywhere in the body. The 60 s loop that dumped diagnostics on giving up, added to chase this, is await_until(|| !finds())again.harness/quarantine.jsondrops its entry.Why
The failure on the runner (this morning's run of pull XRPC failures log their cause, and a query whose connection broke is asked again): "listed to the newcomer 60s after the share was undone: its authority says Err(SpaceNotFound (400): Space not found), they read Ok({}) here". The newcomer was refused and read nothing here, so
readablecould not have listed the private one to them; yet the body held"kept". The server runs with--indexover the shared PDS's firehose, andkeep.rs,mcp.rs(repo_createkept),forge.rsandpages.rsall make public repositories namedkept, which a search forkeptfinds whenever one of them ran before. Locally the binaries rarely overlap, hence never here.How it was checked
Left to CI. The test binary runs in full here; the quarantine no longer covers it, so a failure fails the check.
Shortcomings
None known.