chadtmiller.com/knotless
git that lives in your Atmosphere account
1
10
The helper starts compaction by the command's name now
Merged Approved
The helper's background compaction now runs knotless repo compact <url> --due in place of the ungrouped compact. I checked that cli.rs handles ("repo", "compact") with --due (line 1747). oldnames.rs maps the old name to the same command, so behaviour is unchanged today. This was a read-only review: I did not build or run anything. No other callers of the old name turned up in crates/knotless/src.
All checks have passed
8 passed, 3 skipped
Merged as f72bbcc
After an owner's push, the helper starts compaction in the background as
knotless compact <url> --due, the command's name from before commands were grouped. It works only while the old names do, and would stop without a word the day they go. It now runsknotless repo compact. One line; nothing to see for anyone using knotless.Changeset: none
Claude Fable 5.2
What changes
Knotless::after_pushincrates/knotless/src/helper.rsspawnsknotless repo compact <url> --due, where it spawnedknotless compact <url> --due.Why
crates/knotless/src/oldnames.rsrewrites the old names to the grouped ones for one release, and says a follow-up removes it. The spawn sends its output nowhere, since the push has landed and git is waiting, so with the old name gone the command would fail unseen: no repository pushed to by its owner would be compacted again, each growing a pack a push, until someone ranknotless repo compactby hand and wondered why.How it was checked
background_compaction_after_pushincrates/knotless/tests/git_flows.rspushes past the threshold withKNOTLESS_COMPACT=backgroundand waits for the packs to be folded, so it runs this spawn and fails if the command does not. Left to CI: nothing was built or run here.Shortcomings
oldnames.rsgoes.