chadtmiller.com/knotless
git that lives in your Atmosphere account
Maven metadata releases only what it names; the releases page shows Swift and Maven usage
MergedThis pull does two things. It makes a Maven publish keep each version's uploaded files until its release is made, and it makes maven-metadata.xml release only the versions it names. It also adds Swift and Maven usage cards to the releases page, backed by optional swift and maven strings on releaseView.
I read the changed files, but the Maven pull it is stacked on makes maven.rs a new file. I judged the staging and publish paths as the pull now stands, and found nothing wrong.
- Publish.
publishreads staged versions without removing them. It rejects a metadata file that names an unknown version before releasing anything. It callsforgetonly after the release is made and indexed. A failed publish can therefore be run again, and a version the metadata doesn't name stays staged until the hour is up. - Releases page. The
swiftUseandmavenUsecommands match SwiftPM and Gradle syntax. TheReleaseViewfields are optional and skipped when empty. The lexicon and docs changes line up with them.
I did not run the pull's checks or read their results. The pull says the pages weren't built locally, so web and shots are left to CI.
Since my approval at 644092d, the only change is line wrapping in two paragraphs of ReleaseCard.svelte, which looks like a formatter pass. The text and markup are the same, so what I approved still stands.
Since my approval at bbb766a, the pull has changed only test harness code, none of which touches the Maven or releases-page work I approved.
tls_proxy: each proxy now gets its own hostname under the gateway host, so one PDS can't mistake a later gateway for an earlier one that had the same port.harness/pds.mjs: the test certificate adds a wildcard SAN, anddns.lookupresolves any name under the gateway host to 127.0.0.1.harness/quarantine.json: this drops theracing_gateways_rebuild_on_the_moved_branchentry, which the per-proxy hostnames should fix.
A search for gateway.host found no other caller that depends on the bare hostname. I did not run the tests, so the removed quarantine entry is untested.
1 cancelled, 9 passed, 1 skipped
This answers the reviewer's two notes on the Maven repository and adds Swift and Maven to the releases page. A Maven publish now keeps each version's uploaded files until its release is made, and
maven-metadata.xmlreleases only the versions it names. The releases page shows how to use a Swift package or a Maven artifact, as it already does for crates and npm packages. Stacked on knotless-serve answers Maven's repository layout for a repository's artifacts, so until that lands its diff includes the Maven pull too.Claude Opus 5.5 · high
What changes
A Maven publish loses nothing when a release fails to be made.
Stagingused to take a version's files out of memory before making its release. Nowversionsonly reads them, andforgetdrops them once the release is made. A publish that fails partway can be run again.maven-metadata.xmlreleases only the versions it names. A version uploaded but not named stays in memory until metadata names it, or until the hour is up.The releases page shows how to use the release:
swift package-registry set --scope <scope> <registry>, and.package(id: "<id>", from: "<version>").maven { url = uri("<repository>") }, andimplementation("<group>:<artifact>:<version>").To support this,
dev.knotless.defs#releaseViewgains two optional strings:swift(the identifier as published) andmaven(<group>:<artifact>). The package name alone can't give back the identifier's case, or where the group ends and the artifact begins.docs/design/packages.mdanddocs/reference/api.mdsay both. There is a change file.Why
These are the review's two notes on the Maven pull, and the page work the Swift and Maven pulls left for later, as the npm registry's did.
How it was checked
a_maven_repositorynow covers both notes:a_swift_registryanda_maven_repositoryreadlistReleasesfor the new fields. The staging unit test coversversionsandforget. Run locally: knotless-serve's Maven unit tests, clippy, fmt andharness/lexicons.mjs. The pages weren't built locally, sowebandshotsare left to CI.Shortcomings
The recorded pages have no Swift or Maven release, so the shots check doesn't draw the new card states, and no
just lookpictures of them come with this pull.