chadtmiller.com/monolith
An atproto PDS
OAuth: a PAR with no DPoP proof taken, as the reference takes it
OpenThis takes a PAR with no DPoP proof, as the reference does. The request's key becomes optional, and the code grant binds a keyless request to the token request's proof key. A request that has a key must still match it. I found nothing that must change.
- Spec: it is updated in PAR step 4, step 6, "What is kept", the code grant's step 2, the departures table and the harness description. The Note marks the change as a departure from
atproto/oauth.md. - Code:
exchangecopies the token request'sjktinto the session, and a stored request with no key accepts any proof key there. The MCP issuer's empty key still has to match, as before.settleis skipped when there is no proof, so no proof'sjtiis recorded. - Harness: the draw only adds a case compared against the reference. The only check removed is the server-alone one that held such a PAR to
401, which is no longer the intended behaviour. - Changeset: it is present and written for the people who run the server or call it.
- Not run: I did not run the tests or read the check results.
One small point, which does not block this: an empty dpop_jkt with no proof is kept as Some(""), so that sign-in ends at the code grant with invalid_grant. The pull body already says the reference's answer to that is not compared.
Carried forward: the change this pull makes at d4125e09c5ac336890a3fc45c5b57b536701baf2 is the one reviewed at a8f3c9c35ace1ca8dd1d94bfd5662af83dcf77c7, so that review stands. What is new comes from its base.
1 approval
It lands any minute now, once its batch passes its checks.
1 running, 2 passed, 1 skipped
trezy.pet couldn't sign in with an account on Monolith: its PAR carries no DPoP proof, which Bluesky's PDS takes and Monolith refused
401 invalid_dpop_proof. This takes such a PAR, as the reference does, and marks it in the spec as a departure fromatproto/oauth.mdthat we may drop once clients send proofs at PAR.Claude Opus 5.5 · high
What changes
Spec (
spec/OAUTH.md):DPoPheader is taken, its key bound at the token request. The Note under it says this departs fromatproto/oauth.md, that refusing it is the stricter and right answer, and that it is a candidate to drop.dpop_jktgiven without a proof is kept as the request's key.dpop_jkt.Harness (
harness/checks/oauth.mjs):newRequestsometimes PARs with no proof, with or withoutdpop_jkt, as form or JSON. The whole sign-in after it is compared with the reference.401is removed fromoauthDepartures.pds-server (
oauth.rs), built by a fresh agent given AGENTS.md's step 3 rules and the spec alone:dpop_jkt.par_checks_in_orderruns every refusal again without a proof.a_request_with_no_key_takes_the_token_requestscovers binding, refresh with the bound key, a second key refused and ending the session, anddpop_jktwithout a proof held to its key.Why
From the production log on 2026-11-22: two sign-ins from trezy.pet reached
/oauth/parand were answered401in under a millisecond, with nothing fetched of the client. A PAR with no proof gets exactly that answer. trezy.pet's client, written against Bluesky's PDS, sends its first proof at the token request.How it was checked
main:--only oauthLoginfails at the first PAR without a proof. The reference answers201; the server,401.--only oauthLogin,oauthParRefused,oauthDpopRefused,oauthTokenRefused,oauthDepartures, 80 steps, seeds 1–3, all agree.cargo test -p pds-server --lib -- oauth(83 tests) passes, as the server agent reported. Clippy and fmt are clean.just quickruns here; the full gates are thegatesworkflow.Shortcomings
dpop_jktwithout a proof is kept as a key no proof matches, so that sign-in ends at the code grant withinvalid_grant. The reference's answer to that is not compared.