1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
package social.grain
import androidx.test.ext.junit.runners.AndroidJUnit4
import kotlinx.coroutines.runBlocking
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import social.grain.feature.feed.FeedViewModel
import social.grain.support.Fixtures
import social.grain.support.Harness
import social.grain.support.MainDispatcherRule
import social.grain.support.awaitCall
import social.grain.support.awaitValue
import social.grain.support.json
import social.grain.support.settle
/**
* The feed's own state machine, with the server stubbed out.
*
* Everything here is behaviour a screen test can't see and a decode test
* doesn't reach: which feed the pins resolve to, what a failed refresh leaves
* on screen, and — the one that actually shipped broken once — whether an
* optimistic favorite is put back when the write fails.
*/
@RunWith(AndroidJUnit4::class)
class FeedViewModelTest {
@get:Rule
val mainDispatcher = MainDispatcherRule()
private lateinit var harness: Harness
private val feed = """{"items":[${json(Fixtures.gallery())}],"cursor":"page2"}"""
@Before
fun setUp() {
harness = Harness()
runBlocking { harness.feedCache.purge(harness.did) }
harness.server
.on("social.grain.actor.getPreferences", """{"preferences":[]}""")
.on("social.grain.story.getAuthors", """{"authors":[]}""")
.on("social.grain.feed.getFeed", feed)
}
@After
fun tearDown() {
runBlocking { harness.feedCache.purge(harness.did) }
harness.tearDown()
}
private fun viewModel() = FeedViewModel(
client = harness.client,
auth = harness.auth,
feedCache = harness.feedCache,
viewedStories = harness.viewedStories,
storyStatusCache = harness.storyStatus,
labelDefsCache = harness.labelDefinitions,
)
@Test
fun aColdStartLoadsTheDefaultFeedAndTheSignedInViewer() {
val model = viewModel()
val state = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
assertEquals("A walk in the fog", state.galleries.single().title)
assertEquals("recent", state.selectedFeedId)
assertFalse(state.isLoading)
assertNull(state.errorMessage)
val viewer = model.state.awaitValue("the viewer") { it.viewerDid != null }
assertEquals(harness.did, viewer.viewerDid)
assertEquals(harness.handle, viewer.viewerHandle)
}
@Test
fun theFeedRequestIsAuthenticatedAndNamesTheSelectedFeed() {
viewModel()
val call = harness.server.awaitCall("social.grain.feed.getFeed")
assertEquals("recent", call.params["feed"]?.substringAfterLast('/'))
assertEquals("DPoP test-access", call.authorization)
}
@Test
fun preferencesReplaceTheDefaultPinsAndKeepTheSelectionWhenItSurvives() {
harness.server.on(
"social.grain.actor.getPreferences",
"""{"preferences":[{"${'$'}type":"social.grain.actor.defs#pinnedFeedsPref","items":[
{"id":"recent","label":"Recent","type":"feed","path":"/"},
{"id":"camera:Leica M6","label":"Leica M6","type":"camera","path":"/c"}
]}]}""",
)
val model = viewModel()
val state = model.state.awaitValue("the pins") { it.pinnedFeeds.size == 2 }
assertEquals("recent", state.selectedFeedId)
assertEquals("Leica M6", state.pinnedFeeds[1].label)
}
@Test
fun pinsThatDoNotIncludeTheSelectedFeedFallBackToTheFirstOne() {
harness.server.on(
"social.grain.actor.getPreferences",
"""{"preferences":[{"${'$'}type":"social.grain.actor.defs#pinnedFeedsPref","items":[
{"id":"foryou","label":"For you","type":"feed","path":"/f"}
]}]}""",
)
val model = viewModel()
val state = model.state.awaitValue("the pins") { it.pinnedFeeds.size == 1 }
assertEquals("foryou", state.selectedFeedId)
}
@Test
fun aFollowingFeedSendsTheViewerAsTheActor() {
val model = viewModel()
model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
val before = harness.server.countOf("social.grain.feed.getFeed")
model.selectFeed("following")
val call = harness.server.awaitCall("social.grain.feed.getFeed", count = before + 1)
assertEquals("following", call.params["feed"]?.substringAfterLast('/'))
assertEquals(harness.did, call.params["actor"])
}
@Test
fun aCameraFeedSendsTheCameraRatherThanTheCompoundId() {
harness.server.on(
"social.grain.actor.getPreferences",
"""{"preferences":[{"${'$'}type":"social.grain.actor.defs#pinnedFeedsPref","items":[
{"id":"recent","label":"Recent","type":"feed","path":"/"},
{"id":"camera:Leica M6","label":"Leica M6","type":"camera","path":"/c"}
]}]}""",
)
val model = viewModel()
model.state.awaitValue("the pins and the first page") {
it.pinnedFeeds.size == 2 && it.galleries.isNotEmpty()
}
val before = harness.server.countOf("social.grain.feed.getFeed")
model.selectFeed("camera:Leica M6")
val call = harness.server.awaitCall("social.grain.feed.getFeed", count = before + 1)
assertEquals("camera", call.params["feed"]?.substringAfterLast('/'))
assertEquals("Leica M6", call.params["camera"])
assertNull(call.params["actor"])
}
@Test
fun selectingTheFeedAlreadyShowingDoesNothing() {
val model = viewModel()
model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
val before = harness.server.countOf("social.grain.feed.getFeed")
model.selectFeed("recent")
settle()
assertEquals(before, harness.server.countOf("social.grain.feed.getFeed"))
}
@Test
fun aFailedRefreshKeepsTheGalleriesAndRaisesAMessage() {
val model = viewModel()
model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
harness.server.on("social.grain.feed.getFeed", """{"error":"boom"}""", code = 500)
model.refresh()
val state = model.state.awaitValue("the error") { it.errorMessage != null }
assertEquals(1, state.galleries.size)
assertFalse(state.isRefreshing)
model.dismissError()
assertNull(model.state.value.errorMessage)
}
@Test
fun loadingMoreAppendsThePageBehindTheCursor() {
val model = viewModel()
model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
harness.server.on(
"social.grain.feed.getFeed",
"""{"items":[${json(Fixtures.gallery(rkey = "gallery2", title = "Second"))}]}""",
)
model.loadMore()
val state = model.state.awaitValue("the second page") { it.galleries.size == 2 }
assertEquals("Second", state.galleries[1].title)
assertEquals("page2", harness.server.lastCall("social.grain.feed.getFeed").params["cursor"])
assertFalse(state.isLoadingMore)
}
@Test
fun theEndOfTheFeedStopsLoadingMore() {
harness.server.on("social.grain.feed.getFeed", """{"items":[${json(Fixtures.gallery())}]}""")
val model = viewModel()
model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
val before = harness.server.countOf("social.grain.feed.getFeed")
model.loadMore()
settle()
assertEquals("A cursorless page is the end", before, harness.server.countOf("social.grain.feed.getFeed"))
}
@Test
fun favoritingFlipsTheHeartBeforeTheWriteAndKeepsTheRecordUri() {
harness.server.on("com.atproto.repo.createRecord", """{"uri":"at://did:plc:me/fav/1"}""")
val model = viewModel()
val gallery = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
.galleries.single()
model.toggleFavorite(gallery.uri)
val optimistic = model.state.value.galleries.single()
assertTrue("The heart fills before the write lands", optimistic.isFavorited)
assertEquals(13, optimistic.favCount)
val settled = model.state.awaitValue("the record uri") {
it.galleries.single().viewer?.fav == "at://did:plc:me/fav/1"
}
assertEquals(13, settled.galleries.single().favCount)
}
@Test
fun aFavoriteThatFailsIsPutBack() {
harness.server.on("com.atproto.repo.createRecord", """{"error":"nope"}""", code = 500)
val model = viewModel()
val gallery = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
.galleries.single()
model.toggleFavorite(gallery.uri)
val reverted = model.state.awaitValue("the heart to empty again") {
!it.galleries.single().isFavorited
}
assertEquals(12, reverted.galleries.single().favCount)
}
@Test
fun unfavoritingDeletesTheRecordAndDecrementsTheCount() {
harness.server.on(
"social.grain.feed.getFeed",
"""{"items":[${json(Fixtures.gallery(favUri = "at://did:plc:me/social.grain.favorite/f1"))}]}""",
)
val model = viewModel()
val gallery = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
.galleries.single()
assertTrue(gallery.isFavorited)
model.toggleFavorite(gallery.uri)
val call = harness.server.awaitCall("com.atproto.repo.deleteRecord")
assertTrue(call.body.contains("\"rkey\":\"f1\""))
assertFalse(model.state.value.galleries.single().isFavorited)
assertEquals(11, model.state.value.galleries.single().favCount)
}
@Test
fun favoritingSomethingNotInTheFeedIsIgnored() {
val model = viewModel()
model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
model.toggleFavorite("at://nothing/here")
settle()
assertEquals(0, harness.server.countOf("com.atproto.repo.createRecord"))
}
@Test
fun theCommentCountFollowsTheSheetOpenedOverTheCard() {
val model = viewModel()
val gallery = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
.galleries.single()
model.setCommentCount(gallery.uri, 9)
assertEquals(9, model.state.value.galleries.single().commentCount)
}
@Test
fun deletingAGalleryRemovesTheCardOnlyOnceTheWriteLands() {
val model = viewModel()
val gallery = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
.galleries.single()
model.deleteGallery(gallery.uri)
model.state.awaitValue("the card to go") { it.galleries.isEmpty() }
assertTrue(
harness.server.awaitCall("com.atproto.repo.applyWrites")
.body.contains("gallery1"),
)
}
@Test
fun aDeleteThatFailsLeavesTheCardAndSaysSo() {
harness.server.on(
"com.atproto.repo.applyWrites",
"""{"error":"nope"}""",
code = 500,
)
val model = viewModel()
val gallery = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
.galleries.single()
model.deleteGallery(gallery.uri)
val state = model.state.awaitValue("the error") { it.errorMessage != null }
assertEquals(1, state.galleries.size)
}
@Test
fun theStoryStripIsFilledFromTheAuthorsCall() {
harness.server.on(
"social.grain.story.getAuthors",
"""{"authors":[${json(Fixtures.storyAuthor())},""" +
"""${json(Fixtures.storyAuthor(profile = Fixtures.profile(did = "did:plc:bob"), storyCount = 0))}]}""",
)
val model = viewModel()
val state = model.state.awaitValue("the strip") { it.storyAuthors.isNotEmpty() }
assertEquals("An author with no live story isn't in the strip", 1, state.storyAuthors.size)
assertTrue(harness.storyStatus.hasStory("did:plc:alice"))
assertFalse(model.hasViewedAll(state.storyAuthors.single()))
}
@Test
fun aFailedStoryStripDoesNotTakeTheFeedDownWithIt() {
harness.server.on(
"social.grain.story.getAuthors",
"""{"error":"nope"}""",
code = 500,
)
val model = viewModel()
val state = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
assertTrue(state.storyAuthors.isEmpty())
assertNull(state.errorMessage)
}
@Test
fun closingTheStoryViewerReReadsTheStrip() {
val model = viewModel()
model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
val before = harness.server.countOf("social.grain.story.getAuthors")
model.onStoriesViewed()
harness.server.awaitCall("social.grain.story.getAuthors", count = before + 1)
}
@Test
fun aFreshFeedIsNotReloadedOnReturningToTheApp() {
val model = viewModel()
model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
settle()
val before = harness.server.countOf("social.grain.feed.getFeed")
model.refreshIfStale()
settle()
assertEquals(before, harness.server.countOf("social.grain.feed.getFeed"))
}
@Test
fun theSelectedFeedResolvesThroughThePinsAndFallsBackWhenUnknown() {
val model = viewModel()
val state = model.state.awaitValue("the first page") { it.galleries.isNotEmpty() }
assertEquals("Recent", state.selectedFeed.label)
assertEquals("Recent", state.copy(selectedFeedId = "nope").selectedFeed.label)
}
@Test
fun theCachedPageRendersBeforeTheNetworkAnswers() {
runBlocking {
harness.feedCache.activeDid = harness.did
harness.feedCache.save(listOf(Fixtures.gallery(rkey = "cached", title = "From disk")), "recent")
}
val model = viewModel()
val fromNetwork = model.state.awaitValue("the network page") {
it.galleries.singleOrNull()?.title == "A walk in the fog"
}
assertNotNull(fromNetwork)
}
}